diff options
author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-26 19:31:45 +0000 |
---|---|---|
committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-26 19:31:45 +0000 |
commit | 5f6c5e28735c2aa6a72ad81b1ff6b50d92e9ed90 (patch) | |
tree | ad2882babd5b645da13b60834dfee79110afd9a0 /webkit/glue | |
parent | 324d87b6460e72b43cf416eff8167f591d822276 (diff) | |
download | chromium_src-5f6c5e28735c2aa6a72ad81b1ff6b50d92e9ed90.zip chromium_src-5f6c5e28735c2aa6a72ad81b1ff6b50d92e9ed90.tar.gz chromium_src-5f6c5e28735c2aa6a72ad81b1ff6b50d92e9ed90.tar.bz2 |
The autofill menu does not accept the selection on abandon, such as when pressing ESC.
I had to introduce another acceptOnAbandon member, though the name I came up with is pretty lame.
BUG=4803
TEST=Type some text in a from input text, in the autofill popup menu, use the arrow keys to select something then press ESC. The text input content should not change. Also, make sure the select input still does keep the selection when ESC is pressed.
Review URL: http://codereview.chromium.org/12667
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6042 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue')
-rw-r--r-- | webkit/glue/webview_impl.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/webkit/glue/webview_impl.cc b/webkit/glue/webview_impl.cc index 419c0e2..67285ff 100644 --- a/webkit/glue/webview_impl.cc +++ b/webkit/glue/webview_impl.cc @@ -431,7 +431,6 @@ bool WebViewImpl::KeyEvent(const WebKeyboardEvent& event) { #endif return true; } - return false; } // A new key being pressed should hide the popup. @@ -1516,6 +1515,7 @@ void WebViewImpl::AutofillSuggestionsForNode( WebCore::PopupContainer::create(autocomplete_popup_client_.get(), false); autocomplete_popup_->setTextOnIndexChange(false); + autocomplete_popup_->setAcceptOnAbandon(false); autocomplete_popup_->show(focused_node->getRect(), page_->mainFrame()->view(), 0); } |