diff options
| author | pamg@google.com <pamg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-23 00:15:06 +0000 |
|---|---|---|
| committer | pamg@google.com <pamg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-23 00:15:06 +0000 |
| commit | f48c32b784499082892d907d41ca4bc4044ff108 (patch) | |
| tree | a8314fceb3094183db979a6f9c854505b78191b4 /webkit/glue | |
| parent | 8a48b1e14b7b4987bc7b60002db2ee17f69cb7c6 (diff) | |
| download | chromium_src-f48c32b784499082892d907d41ca4bc4044ff108.zip chromium_src-f48c32b784499082892d907d41ca4bc4044ff108.tar.gz chromium_src-f48c32b784499082892d907d41ca4bc4044ff108.tar.bz2 | |
Expand comment for shouldUseCredentialStorage stub, explaining what it might
eventually do.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/16433
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7396 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue')
| -rw-r--r-- | webkit/glue/webframeloaderclient_impl.cc | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/webkit/glue/webframeloaderclient_impl.cc b/webkit/glue/webframeloaderclient_impl.cc index d10749d..a402c8f 100644 --- a/webkit/glue/webframeloaderclient_impl.cc +++ b/webkit/glue/webframeloaderclient_impl.cc @@ -211,12 +211,18 @@ void WebFrameLoaderClient::dispatchWillSendRequest( bool WebFrameLoaderClient::shouldUseCredentialStorage(DocumentLoader*, unsigned long identifier) { // FIXME - // Intended to call a method on the resource load delegate. - // Returns true for backward compatibility. + // Intended to pass through to a method on the resource load delegate. + // If implemented, that method controls whether the browser should ask the + // networking layer for a stored default credential for the page (say from + // the Mac OS keychain). If the method returns false, the user should be + // presented with an authentication challenge whether or not the networking + // layer has a credential stored. + // This returns true for backward compatibility: the ability to override the + // system credential store is new. (Actually, not yet fully implemented in + // WebKit, as of this writing.) return true; } - void WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge( DocumentLoader*, unsigned long identifier, const AuthenticationChallenge&) { // FIXME |