diff options
| author | rsimha@chromium.org <rsimha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-23 01:02:30 +0000 |
|---|---|---|
| committer | rsimha@chromium.org <rsimha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-23 01:02:30 +0000 |
| commit | d3e940fb09ffeefad463627b24751a374c7a2e87 (patch) | |
| tree | d1e386b62f9226ac9a354193cfb4fc7be2760174 /webkit/glue | |
| parent | dd856dfd5ce52bf74131726882c30bf3eb0de3c3 (diff) | |
| download | chromium_src-d3e940fb09ffeefad463627b24751a374c7a2e87.zip chromium_src-d3e940fb09ffeefad463627b24751a374c7a2e87.tar.gz chromium_src-d3e940fb09ffeefad463627b24751a374c7a2e87.tar.bz2 | |
Full refactor / rewrite of bookmark sync integration tests
The LiveBookmarksSyncTest and BookmarkModelVerifier classes were designed over a year ago and are badly in need of a refactor. Bookmark sync integration test cases are extremely cumbersome to write, review and read, with individual tests requiring a lot of repeated code.
This patch contains the following:
- A refactor of the BookmarkModelVerifier class.
- A major update to the LiveBookmarksSyncTest class, providing test cases with a bunch of new easy-to-use methods to perform various bookmark operations.
- A complete rewrite of every single bookmark sync integration test case using the new methods. (phew!)
In addition, this patch does the following:
- Replaces all instances of EXPECT_* in test cases with ASSERT_*, thereby avoiding several pages of irrelevant logs in case of failures, and making logs a lot easier to read.
- Annotates a few methods with WARN_UNUSED_RESULT so that test cases are forced to verify their results before proceeding.
BUG=59301,56043,19769
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/3971003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63606 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue')
0 files changed, 0 insertions, 0 deletions