summaryrefslogtreecommitdiffstats
path: root/webkit/glue
diff options
context:
space:
mode:
authorpinkerton@chromium.org <pinkerton@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-27 19:29:37 +0000
committerpinkerton@chromium.org <pinkerton@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-27 19:29:37 +0000
commit9abc1b14a6042d4575d2817b275acb6c241ec543 (patch)
tree4edb1a070afa8c8a66057a78bfdd49c9f1f17374 /webkit/glue
parent51d5e16054c2e9c64e9357c171166f8bda6f5af5 (diff)
downloadchromium_src-9abc1b14a6042d4575d2817b275acb6c241ec543.zip
chromium_src-9abc1b14a6042d4575d2817b275acb6c241ec543.tar.gz
chromium_src-9abc1b14a6042d4575d2817b275acb6c241ec543.tar.bz2
Roll to WebKit 46417. DevTools: Migrate from InspectorController to InspectorBackend.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21680 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue')
-rw-r--r--webkit/glue/webdevtoolsagent_impl.cc9
-rw-r--r--webkit/glue/webdevtoolsclient_impl.cc25
2 files changed, 8 insertions, 26 deletions
diff --git a/webkit/glue/webdevtoolsagent_impl.cc b/webkit/glue/webdevtoolsagent_impl.cc
index d61f3b7..3cbfca2 100644
--- a/webkit/glue/webdevtoolsagent_impl.cc
+++ b/webkit/glue/webdevtoolsagent_impl.cc
@@ -317,15 +317,10 @@ void WebDevToolsAgentImpl::InitDevToolsAgentHost() {
v8::HandleScope scope;
v8::Context::Scope utility_scope(utility_context_);
InspectorController* ic = web_view_impl_->page()->inspectorController();
- // There is a breaking change pending upstream. INSPECTORCONTROLLER was
- // replaced with INSPECTORBACKEND. Following code should be replaced with:
- // utility_context_->Global()->Set(
- // v8::String::New("InspectorController"),
- // V8DOMWrapper::convertToV8Object(V8ClassIndex::INSPECTORBACKEND,
- // ic->inspectorBackend()));
utility_context_->Global()->Set(
v8::String::New("InspectorController"),
- V8DOMWrapper::convertToV8Object(V8ClassIndex::INSPECTORCONTROLLER, ic));
+ V8DOMWrapper::convertToV8Object(V8ClassIndex::INSPECTORBACKEND,
+ ic->inspectorBackend()));
}
// static
diff --git a/webkit/glue/webdevtoolsclient_impl.cc b/webkit/glue/webdevtoolsclient_impl.cc
index 4c25481..6095e61 100644
--- a/webkit/glue/webdevtoolsclient_impl.cc
+++ b/webkit/glue/webdevtoolsclient_impl.cc
@@ -9,6 +9,7 @@
#include "Document.h"
#include "DOMWindow.h"
#include "Frame.h"
+#include "InspectorBackend.h"
#include "InspectorController.h"
#include "Node.h"
#include "Page.h"
@@ -68,12 +69,9 @@ class ToolsAgentNativeDelegateImpl : public ToolsAgentNativeDelegate {
InspectorController* ic = frame_->frame()->page()->inspectorController();
if (request.frame && request.frame->attached()) {
- // There is a breaking change pending upstream. addSourceToFrame now
- // lives in InspectorBackend. Following code should be replaced with:
- // ic->inspectorBackend()->addSourceToFrame(request.mime_type,
- // content,
- // request.frame.get());
- ic->addSourceToFrame(request.mime_type, content, request.frame.get());
+ ic->inspectorBackend()->addSourceToFrame(request.mime_type,
+ content,
+ request.frame.get());
}
}
@@ -168,16 +166,9 @@ WebDevToolsClientImpl::WebDevToolsClientImpl(
dev_tools_host_->AddProtoFunction(
"loaded",
WebDevToolsClientImpl::JsLoaded);
- // There is a breaking change pending upstream.
- // v8InspectorControllerSearchCallback is now
- // v8InspectorBackendSearchCallback.
- // Following code should be replaced with:
- // dev_tools_host_->AddProtoFunction(
- // "search",
- // WebCore::V8Custom::v8InspectorBackendSearchCallback);
dev_tools_host_->AddProtoFunction(
"search",
- WebCore::V8Custom::v8InspectorControllerSearchCallback);
+ WebCore::V8Custom::v8InspectorBackendSearchCallback);
dev_tools_host_->AddProtoFunction(
"getPlatform",
WebDevToolsClientImpl::JsGetPlatform);
@@ -285,11 +276,7 @@ v8::Handle<v8::Value> WebDevToolsClientImpl::JsAddSourceToFrame(
Page* page = V8Proxy::retrieveFrameForEnteredContext()->page();
InspectorController* inspectorController = page->inspectorController();
- // There is a breaking change pending upstream. Following code should be
- // replaced with:
- // return WebCore::v8Boolean(inspectorController->inspectorBackend()->
- // addSourceToFrame(mime_type, source_string, node));
- return WebCore::v8Boolean(inspectorController->
+ return WebCore::v8Boolean(inspectorController->inspectorBackend()->
addSourceToFrame(mime_type, source_string, node));
}