summaryrefslogtreecommitdiffstats
path: root/webkit/media
diff options
context:
space:
mode:
authorxhwang@chromium.org <xhwang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-05-24 23:20:54 +0000
committerxhwang@chromium.org <xhwang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-05-24 23:20:54 +0000
commit98f60edd0302dba3ccff439fb9e799e377248c93 (patch)
tree64173dd97fa352720f23d749472dba5d7a55701e /webkit/media
parent83fcab4fe5c04ef3bfe0d77c85d4c674c67ee68e (diff)
downloadchromium_src-98f60edd0302dba3ccff439fb9e799e377248c93.zip
chromium_src-98f60edd0302dba3ccff439fb9e799e377248c93.tar.gz
chromium_src-98f60edd0302dba3ccff439fb9e799e377248c93.tar.bz2
Remove unit8_t from WebMediaPlayer implementations.
This is the chromium side change of https://codereview.chromium.org/15857006. BUG=243347 TEST=Everything still compiles. R=acolwell@chromium.org Review URL: https://codereview.chromium.org/15784006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202219 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/media')
-rw-r--r--webkit/media/android/webmediaplayer_android.cc2
-rw-r--r--webkit/media/android/webmediaplayer_android.h2
-rw-r--r--webkit/media/crypto/proxy_decryptor.cc6
-rw-r--r--webkit/media/webmediaplayer_impl.cc2
-rw-r--r--webkit/media/webmediaplayer_impl.h2
-rw-r--r--webkit/media/webmediaplayer_ms.cc2
-rw-r--r--webkit/media/webmediaplayer_ms.h2
7 files changed, 7 insertions, 11 deletions
diff --git a/webkit/media/android/webmediaplayer_android.cc b/webkit/media/android/webmediaplayer_android.cc
index 3dfd945..cc88632 100644
--- a/webkit/media/android/webmediaplayer_android.cc
+++ b/webkit/media/android/webmediaplayer_android.cc
@@ -287,7 +287,7 @@ void WebMediaPlayerAndroid::setSize(const WebKit::WebSize& size) {
void WebMediaPlayerAndroid::paint(WebKit::WebCanvas* canvas,
const WebKit::WebRect& rect,
- uint8_t alpha) {
+ unsigned char alpha) {
NOTIMPLEMENTED();
}
diff --git a/webkit/media/android/webmediaplayer_android.h b/webkit/media/android/webmediaplayer_android.h
index 7d45d3713..ce4f95e 100644
--- a/webkit/media/android/webmediaplayer_android.h
+++ b/webkit/media/android/webmediaplayer_android.h
@@ -91,7 +91,7 @@ class WebMediaPlayerAndroid
virtual void setSize(const WebKit::WebSize& size);
virtual void paint(WebKit::WebCanvas* canvas,
const WebKit::WebRect& rect,
- uint8_t alpha);
+ unsigned char alpha);
virtual bool copyVideoTextureToPlatformTexture(
WebKit::WebGraphicsContext3D* web_graphics_context,
diff --git a/webkit/media/crypto/proxy_decryptor.cc b/webkit/media/crypto/proxy_decryptor.cc
index 3e445c4..1a87024 100644
--- a/webkit/media/crypto/proxy_decryptor.cc
+++ b/webkit/media/crypto/proxy_decryptor.cc
@@ -13,14 +13,10 @@
#if defined(ENABLE_PEPPER_CDMS)
#include "third_party/WebKit/Source/Platform/chromium/public/WebString.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebMediaPlayerClient.h"
#include "webkit/media/crypto/ppapi_decryptor.h"
#include "webkit/plugins/ppapi/ppapi_plugin_instance.h"
#include "webkit/plugins/ppapi/ppapi_webplugin_impl.h"
-// TODO(xhwang): Put this include after "ppapi_plugin_instance.h" for definition
-// of "uint8_t", which WebMediaPlayer.h uses without including a header for it.
-// See: https://bugs.webkit.org/show_bug.cgi?id=92031
-// Fix include order here when the bug is fixed.
-#include "third_party/WebKit/Source/WebKit/chromium/public/WebMediaPlayerClient.h"
#endif // defined(ENABLE_PEPPER_CDMS)
namespace webkit_media {
diff --git a/webkit/media/webmediaplayer_impl.cc b/webkit/media/webmediaplayer_impl.cc
index 140a1e9..481c0da 100644
--- a/webkit/media/webmediaplayer_impl.cc
+++ b/webkit/media/webmediaplayer_impl.cc
@@ -521,7 +521,7 @@ void WebMediaPlayerImpl::setSize(const WebSize& size) {
void WebMediaPlayerImpl::paint(WebCanvas* canvas,
const WebRect& rect,
- uint8_t alpha) {
+ unsigned char alpha) {
DCHECK(main_loop_->BelongsToCurrentThread());
if (!accelerated_compositing_reported_) {
diff --git a/webkit/media/webmediaplayer_impl.h b/webkit/media/webmediaplayer_impl.h
index 00f9a9f..53cb42f 100644
--- a/webkit/media/webmediaplayer_impl.h
+++ b/webkit/media/webmediaplayer_impl.h
@@ -112,7 +112,7 @@ class WebMediaPlayerImpl
virtual void paint(WebKit::WebCanvas* canvas,
const WebKit::WebRect& rect,
- uint8_t alpha);
+ unsigned char alpha);
// True if the loaded media has a playable video/audio track.
virtual bool hasVideo() const;
diff --git a/webkit/media/webmediaplayer_ms.cc b/webkit/media/webmediaplayer_ms.cc
index 4ecfeee..2b5cdd2 100644
--- a/webkit/media/webmediaplayer_ms.cc
+++ b/webkit/media/webmediaplayer_ms.cc
@@ -306,7 +306,7 @@ void WebMediaPlayerMS::setSize(const WebSize& size) {
void WebMediaPlayerMS::paint(WebCanvas* canvas,
const WebRect& rect,
- uint8_t alpha) {
+ unsigned char alpha) {
DVLOG(3) << "WebMediaPlayerMS::paint";
DCHECK(thread_checker_.CalledOnValidThread());
diff --git a/webkit/media/webmediaplayer_ms.h b/webkit/media/webmediaplayer_ms.h
index 5213ca9..580dff9 100644
--- a/webkit/media/webmediaplayer_ms.h
+++ b/webkit/media/webmediaplayer_ms.h
@@ -88,7 +88,7 @@ class WebMediaPlayerMS
virtual void paint(WebKit::WebCanvas* canvas,
const WebKit::WebRect& rect,
- uint8_t alpha) OVERRIDE;
+ unsigned char alpha) OVERRIDE;
// True if the loaded media has a playable video/audio track.
virtual bool hasVideo() const OVERRIDE;