Correctly lookup PluginGroup for a given WebPluginInfo.

If a WebPluginInfo had an empty name, we wouldn't find it in the list of plug-in groups, and repeatedly add it, causing the list to grow every time.

Fix this by a) matching plug-ins based on the path, and b) not adding plug-ins which are not found to the PluginList.

BUG=97655
TEST=see bug


Review URL: http://codereview.chromium.org/8050014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102979 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 0 insertions, 7 deletions

diff --git a/webkit/plugins/npapi/plugin_list.h b/webkit/plugins/npapi/plugin_list.h
index 59ce1f0..6c7cdee 100644
--- a/webkit/plugins/npapi/plugin_list.h
+++ b/webkit/plugins/npapi/plugin_list.h
@@ -160,7 +160,6 @@ class PluginList {
                        std::vector<PluginGroup>* plugin_groups);
 
   // Returns a copy of the PluginGroup corresponding to the given WebPluginInfo.
-  // If no such group exists, it is created and added to the cache.
   // The caller takes ownership of the returned PluginGroup.
   PluginGroup* GetPluginGroup(const webkit::WebPluginInfo& web_plugin_info);
 
@@ -168,12 +167,6 @@ class PluginList {
   // If no such group exists, an empty string is returned.
   string16 GetPluginGroupName(const std::string& identifier);
 
-  // Returns the identifier string of the PluginGroup corresponding to the given
-  // WebPluginInfo. If no such group exists, it is created and added to the
-  // cache.
-  std::string GetPluginGroupIdentifier(
-      const webkit::WebPluginInfo& web_plugin_info);
-
   // Load a specific plugin with full path.
   void LoadPlugin(const FilePath& filename,
                   ScopedVector<PluginGroup>* plugin_groups);