diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-18 01:50:31 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-18 01:50:31 +0000 |
| commit | 9ca245e3b2d0e2271c7124d3aceb8179903718e2 (patch) | |
| tree | aa5fdbad23bd9a91cb117c1610064242d8a00985 /webkit/plugins/ppapi/ppb_audio_impl.cc | |
| parent | a2f013ebcd62eae5238ca4ee84b9d21e34197fd8 (diff) | |
| download | chromium_src-9ca245e3b2d0e2271c7124d3aceb8179903718e2.zip chromium_src-9ca245e3b2d0e2271c7124d3aceb8179903718e2.tar.gz chromium_src-9ca245e3b2d0e2271c7124d3aceb8179903718e2.tar.bz2 | |
Implement a proxy for URL util. Some of the implementation that doesn't need to
be proxied moved into a new shared_impl file, which required a decent amount of
glue to make it callable from both the implementation and the proxy. The payoff
here is only marginal since the code is fairly simple, but I decided this is
still better than duplication.
This also includes some comments from my audio patch that I forgot in that CL.
BUG=none
TEST=ppapi_tests run out of process pass
Review URL: http://codereview.chromium.org/6676045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78646 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/plugins/ppapi/ppb_audio_impl.cc')
| -rw-r--r-- | webkit/plugins/ppapi/ppb_audio_impl.cc | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/webkit/plugins/ppapi/ppb_audio_impl.cc b/webkit/plugins/ppapi/ppb_audio_impl.cc index 1a36e70..0d4f852 100644 --- a/webkit/plugins/ppapi/ppb_audio_impl.cc +++ b/webkit/plugins/ppapi/ppb_audio_impl.cc @@ -220,7 +220,11 @@ PPB_Audio_Impl::PPB_Audio_Impl(PluginInstance* instance) } PPB_Audio_Impl::~PPB_Audio_Impl() { - // Calling ShutDown() makes sure StreamCreated cannot be called anymore. + // Calling ShutDown() makes sure StreamCreated cannot be called anymore and + // releases the audio data associated with the pointer. Note however, that + // until ShutDown returns, StreamCreated may still be called. This will be + // OK since we'll just immediately clean up the data it stored later in this + // destructor. if (audio_) { audio_->ShutDown(); audio_ = NULL; |