diff options
author | shenhan@google.com <shenhan@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-05 01:54:46 +0000 |
---|---|---|
committer | shenhan@google.com <shenhan@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-05 01:54:46 +0000 |
commit | 3fcbd4b4db3bb67e5e3d10944335c3a91f22723e (patch) | |
tree | 3e35507ef2b232faf4f672f1a5f450d4c8b151ca /webkit/plugins | |
parent | 34d4ebbfd10b704f4f9be87a74e2e072c4dec081 (diff) | |
download | chromium_src-3fcbd4b4db3bb67e5e3d10944335c3a91f22723e.zip chromium_src-3fcbd4b4db3bb67e5e3d10944335c3a91f22723e.tar.gz chromium_src-3fcbd4b4db3bb67e5e3d10944335c3a91f22723e.tar.bz2 |
Fixing gcc 4.7 building problems.
a) - gcc-4.7 improved the implicit headers that it includes. with
<4.7, the gthr-default.h file always pulls in unistd.h. with >=4.7,
they avoided that include when possible. so code that isn't including
unistd.h itself but needs it now breaks.
b) - narrowing conversion in initiliazation list now raises an
'ill-formed conversion' warning, which causes error when -Werror is
given.
[THIS PART IS NOW REVERTED IN THE PATCH} c) - included patches from pastebin - http://pastebin.com/raw.php?i=p3UKs7Cg
Note - this may not be fixing all the gcc 4.7 build problems for all
parts, but rather than submitting one big-fix-for-all CL, we'd better
do it incrementally (given that all the modification is reasonable and
minor) so that at least some parts get a successful gcc 4.7 build.
BUG=None
TEST=Built successfully using GCC-4.7 under chromium chroot
Review URL: https://chromiumcodereview.appspot.com/10451068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140470 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/plugins')
-rw-r--r-- | webkit/plugins/ppapi/ppb_flash_impl.cc | 7 | ||||
-rw-r--r-- | webkit/plugins/ppapi/ppb_video_capture_impl.cc | 6 |
2 files changed, 7 insertions, 6 deletions
diff --git a/webkit/plugins/ppapi/ppb_flash_impl.cc b/webkit/plugins/ppapi/ppb_flash_impl.cc index 668a8c1..9290ba0 100644 --- a/webkit/plugins/ppapi/ppb_flash_impl.cc +++ b/webkit/plugins/ppapi/ppb_flash_impl.cc @@ -124,9 +124,10 @@ PP_Bool PPB_Flash_Impl::DrawGlyphs(PP_Instance instance, SkAutoCanvasRestore acr(canvas, true); // Clip is applied in pixels before the transform. - SkRect clip_rect = { clip->point.x, clip->point.y, - clip->point.x + clip->size.width, - clip->point.y + clip->size.height }; + SkRect clip_rect = { SkIntToScalar(clip->point.x), + SkIntToScalar(clip->point.y), + SkIntToScalar(clip->point.x + clip->size.width), + SkIntToScalar(clip->point.y + clip->size.height) }; canvas->clipRect(clip_rect); // Convert & set the matrix. diff --git a/webkit/plugins/ppapi/ppb_video_capture_impl.cc b/webkit/plugins/ppapi/ppb_video_capture_impl.cc index f1eb12c..9a00155 100644 --- a/webkit/plugins/ppapi/ppb_video_capture_impl.cc +++ b/webkit/plugins/ppapi/ppb_video_capture_impl.cc @@ -118,9 +118,9 @@ void PPB_VideoCapture_Impl::OnDeviceInfoReceived( media::VideoCapture* capture, const media::VideoCaptureParams& device_info) { PP_VideoCaptureDeviceInfo_Dev info = { - device_info.width, - device_info.height, - device_info.frame_per_second + static_cast<uint32_t>(device_info.width), + static_cast<uint32_t>(device_info.height), + static_cast<uint32_t>(device_info.frame_per_second) }; ReleaseBuffers(); |