diff options
| author | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-12 19:24:19 +0000 |
|---|---|---|
| committer | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-12 19:24:19 +0000 |
| commit | 9cb116d30b6d6a52f11270abf7cea80bfa7fc738 (patch) | |
| tree | d8f7830616d76dd577fdab91df1d622d95096877 /webkit/plugins | |
| parent | b9866ebc631655c593a2ac60a3c7cf7d217ccf5d (diff) | |
| download | chromium_src-9cb116d30b6d6a52f11270abf7cea80bfa7fc738.zip chromium_src-9cb116d30b6d6a52f11270abf7cea80bfa7fc738.tar.gz chromium_src-9cb116d30b6d6a52f11270abf7cea80bfa7fc738.tar.bz2 | |
Method parameter name change in ppb_file_io_impl.* ...
... per review at <http://codereview.chromium.org/6228004>.
BUG=none
TEST=builds
TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/6157009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71212 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/plugins')
| -rw-r--r-- | webkit/plugins/ppapi/ppb_file_io_impl.cc | 4 | ||||
| -rw-r--r-- | webkit/plugins/ppapi/ppb_file_io_impl.h | 5 |
2 files changed, 5 insertions, 4 deletions
diff --git a/webkit/plugins/ppapi/ppb_file_io_impl.cc b/webkit/plugins/ppapi/ppb_file_io_impl.cc index 3067e94..6440d16 100644 --- a/webkit/plugins/ppapi/ppb_file_io_impl.cc +++ b/webkit/plugins/ppapi/ppb_file_io_impl.cc @@ -401,7 +401,7 @@ int32_t PPB_FileIO_Impl::WillSetLength(int64_t length, return PP_OK; } -int32_t PPB_FileIO_Impl::CommonCallValidation(bool is_opened, +int32_t PPB_FileIO_Impl::CommonCallValidation(bool should_be_open, PP_CompletionCallback callback) { // Only asynchronous operation is supported. if (!callback.func) { @@ -409,7 +409,7 @@ int32_t PPB_FileIO_Impl::CommonCallValidation(bool is_opened, return PP_ERROR_BADARGUMENT; } - if (is_opened) { + if (should_be_open) { if (file_ == base::kInvalidPlatformFileValue) return PP_ERROR_FAILED; } else { diff --git a/webkit/plugins/ppapi/ppb_file_io_impl.h b/webkit/plugins/ppapi/ppb_file_io_impl.h index 16da265..0743fdb 100644 --- a/webkit/plugins/ppapi/ppb_file_io_impl.h +++ b/webkit/plugins/ppapi/ppb_file_io_impl.h @@ -77,11 +77,12 @@ class PPB_FileIO_Impl : public Resource { private: // Verifies: // - that |callback| is valid (only nonblocking operation supported); - // - that the file is already opened or not (depending on |is_opened|); and + // - that the file is already open or not, depending on |should_be_open|; and // - that no callback is already pending. // Returns |PP_OK| to indicate that everything is valid or |PP_ERROR_...| if // the call should be aborted and that code returned to the plugin. - int32_t CommonCallValidation(bool is_opened, PP_CompletionCallback callback); + int32_t CommonCallValidation(bool should_be_open, + PP_CompletionCallback callback); // Sets up |callback| as the pending callback. This should only be called once // it is certain that |PP_ERROR_WOULDBLOCK| will be returned. |