summaryrefslogtreecommitdiffstats
path: root/webkit/plugins
diff options
context:
space:
mode:
authorcevans@chromium.org <cevans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-02-02 07:52:11 +0000
committercevans@chromium.org <cevans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-02-02 07:52:11 +0000
commita2b7c7b35054f37b8bc33e99f7adaf394183f061 (patch)
tree7479f2f6e71a556c6c732aa3ebf65dc0c09fe528 /webkit/plugins
parentd8b8f76e0ed6cabeef6f9584ad44a6f6b794d511 (diff)
downloadchromium_src-a2b7c7b35054f37b8bc33e99f7adaf394183f061.zip
chromium_src-a2b7c7b35054f37b8bc33e99f7adaf394183f061.tar.gz
chromium_src-a2b7c7b35054f37b8bc33e99f7adaf394183f061.tar.bz2
Activate / fix the NPAPI plugin test on Linux:
- My install won't tolerate NULLs to XQueryTree(), so fix. - Need to flag the test plug-in as NOT an Xt-based plug-in. - Enable the test in the .gypi. BUG=30700 TEST=ui_tests,NPAPI*.* Review URL: http://codereview.chromium.org/6349042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73434 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/plugins')
-rw-r--r--webkit/plugins/npapi/test/plugin_client.cc5
-rw-r--r--webkit/plugins/npapi/test/plugin_javascript_open_popup.cc6
2 files changed, 10 insertions, 1 deletions
diff --git a/webkit/plugins/npapi/test/plugin_client.cc b/webkit/plugins/npapi/test/plugin_client.cc
index 527485d..2c27f63 100644
--- a/webkit/plugins/npapi/test/plugin_client.cc
+++ b/webkit/plugins/npapi/test/plugin_client.cc
@@ -208,6 +208,11 @@ NPError NPP_GetValue(NPP instance, NPPVariable variable, void *value) {
if (instance == NULL)
return NPERR_INVALID_INSTANCE_ERROR;
+ if (variable == NPPVpluginNeedsXEmbed) {
+ *static_cast<NPBool*>(value) = 1;
+ return NPERR_NO_ERROR;
+ }
+
// XXXMB - do work here.
return NPERR_GENERIC_ERROR;
}
diff --git a/webkit/plugins/npapi/test/plugin_javascript_open_popup.cc b/webkit/plugins/npapi/test/plugin_javascript_open_popup.cc
index 583a55e..468b8d5 100644
--- a/webkit/plugins/npapi/test/plugin_javascript_open_popup.cc
+++ b/webkit/plugins/npapi/test/plugin_javascript_open_popup.cc
@@ -82,8 +82,12 @@ bool ExecuteJavascriptPopupWindowTargetPluginTest::CheckWindow(
if (xwindow) {
Window root, parent;
+ Window* wins = NULL;
+ unsigned int num_child;
Status status = XQueryTree(extra->display, xwindow, &root, &parent,
- NULL, NULL); // NULL children info.
+ &wins, &num_child);
+ if (wins)
+ XFree(wins);
DCHECK(status != 0);
if (!parent || parent == root)
SetError("Windowed plugin instantiated with NULL parent");