summaryrefslogtreecommitdiffstats
path: root/webkit/plugins
diff options
context:
space:
mode:
authormrossetti@chromium.org <mrossetti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-06-22 19:24:11 +0000
committermrossetti@chromium.org <mrossetti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-06-22 19:24:11 +0000
commit3b0d77670a0613f409110817455d2137576b485a (patch)
tree235e9caa9db9a542e086db40c4dba249cb4e8d05 /webkit/plugins
parent4d4ee4c3db819fb3f46381e99608a156458e3ecb (diff)
downloadchromium_src-3b0d77670a0613f409110817455d2137576b485a.zip
chromium_src-3b0d77670a0613f409110817455d2137576b485a.tar.gz
chromium_src-3b0d77670a0613f409110817455d2137576b485a.tar.bz2
Revert 143656 - Add an IPC channel between the NaCl loader process and the renderer.
BUG=116317 TEST=ppapi, nacl tests, manual testing for experimental IPC proxy. Review URL: https://chromiumcodereview.appspot.com/10641016 TBR=bbudge@chromium.org Review URL: https://chromiumcodereview.appspot.com/10625007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143665 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/plugins')
-rw-r--r--webkit/plugins/ppapi/plugin_module.cc16
-rw-r--r--webkit/plugins/ppapi/plugin_module.h4
2 files changed, 4 insertions, 16 deletions
diff --git a/webkit/plugins/ppapi/plugin_module.cc b/webkit/plugins/ppapi/plugin_module.cc
index 423209f..a16f79a 100644
--- a/webkit/plugins/ppapi/plugin_module.cc
+++ b/webkit/plugins/ppapi/plugin_module.cc
@@ -419,8 +419,7 @@ PluginModule::PluginModule(const std::string& name,
library_(NULL),
name_(name),
path_(path),
- reserve_instance_id_(NULL),
- nacl_ipc_proxy_(false) {
+ reserve_instance_id_(NULL) {
// Ensure the globals object is created.
if (!host_globals)
host_globals = new HostGlobals;
@@ -497,13 +496,9 @@ void PluginModule::InitAsProxied(
}
void PluginModule::InitAsProxiedNaCl(
- scoped_ptr<PluginDelegate::OutOfProcessProxy> out_of_process_proxy,
+ PluginDelegate::OutOfProcessProxy* out_of_process_proxy,
PP_Instance instance) {
- // TODO(bbudge) We need to switch the mode of the PluginModule on a
- // per-instance basis. Fix this so out_of_process_proxy and other
- // state is stored in a map, indexed by instance.
- nacl_ipc_proxy_ = true;
- InitAsProxied(out_of_process_proxy.release());
+ InitAsProxied(out_of_process_proxy);
// InitAsProxied (for the trusted/out-of-process case) initializes only the
// module, and one or more instances are added later. In this case, the
// PluginInstance was already created as in-process, so we missed the proxy
@@ -565,11 +560,6 @@ void PluginModule::InstanceDeleted(PluginInstance* instance) {
if (out_of_process_proxy_.get())
out_of_process_proxy_->RemoveInstance(instance->pp_instance());
instances_.erase(instance);
-
- if (nacl_ipc_proxy_) {
- out_of_process_proxy_.reset();
- reserve_instance_id_ = NULL;
- }
}
scoped_refptr< ::ppapi::CallbackTracker> PluginModule::GetCallbackTracker() {
diff --git a/webkit/plugins/ppapi/plugin_module.h b/webkit/plugins/ppapi/plugin_module.h
index d9d78ba..d9b0162 100644
--- a/webkit/plugins/ppapi/plugin_module.h
+++ b/webkit/plugins/ppapi/plugin_module.h
@@ -90,7 +90,7 @@ class WEBKIT_PLUGINS_EXPORT PluginModule :
// Initializes this module for the given NaCl proxy. This takes
// ownership of the given pointer, even in the failure case.
void InitAsProxiedNaCl(
- scoped_ptr<PluginDelegate::OutOfProcessProxy> out_of_process_proxy,
+ PluginDelegate::OutOfProcessProxy* out_of_process_proxy,
PP_Instance instance);
static const PPB_Core* GetCore();
@@ -203,8 +203,6 @@ class WEBKIT_PLUGINS_EXPORT PluginModule :
PP_Bool (*reserve_instance_id_)(PP_Module, PP_Instance);
- bool nacl_ipc_proxy_;
-
DISALLOW_COPY_AND_ASSIGN(PluginModule);
};