summaryrefslogtreecommitdiffstats
path: root/webkit/plugins
diff options
context:
space:
mode:
authorhans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-05-25 09:08:19 +0000
committerhans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-05-25 09:08:19 +0000
commit3690ebe09a8c3cea0fd7d9ece8f5b8d8ebc65c19 (patch)
treeb26f7f81e48a95473eb4af5304301e9d8cd22fb8 /webkit/plugins
parenteef99b6591d82399096abdcee07dd67359eec036 (diff)
downloadchromium_src-3690ebe09a8c3cea0fd7d9ece8f5b8d8ebc65c19.zip
chromium_src-3690ebe09a8c3cea0fd7d9ece8f5b8d8ebc65c19.tar.gz
chromium_src-3690ebe09a8c3cea0fd7d9ece8f5b8d8ebc65c19.tar.bz2
Virtual destructors should have virtual keyword.
Make sure user-declared virtual destructors always have the virtual keyword. The Clang style-check plugin will check for this soon. No functionality change: virtual is only added to destructors that are already implicitly virtual. Also fix a couple of in-line destructor definitions. BUG=83408 TEST=none Review URL: http://codereview.chromium.org/7064033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86587 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/plugins')
-rw-r--r--webkit/plugins/npapi/test/plugin_npobject_lifetime_test.h4
-rw-r--r--webkit/plugins/npapi/test/plugin_thread_async_call_test.h2
-rw-r--r--webkit/plugins/npapi/webplugin_delegate_impl.h2
-rw-r--r--webkit/plugins/ppapi/ppb_audio_impl.h2
4 files changed, 5 insertions, 5 deletions
diff --git a/webkit/plugins/npapi/test/plugin_npobject_lifetime_test.h b/webkit/plugins/npapi/test/plugin_npobject_lifetime_test.h
index 12cf4e2..8365b9b 100644
--- a/webkit/plugins/npapi/test/plugin_npobject_lifetime_test.h
+++ b/webkit/plugins/npapi/test/plugin_npobject_lifetime_test.h
@@ -41,7 +41,7 @@ class NPObjectLifetimeTestInstance2 : public PluginTest {
public:
// Constructor.
NPObjectLifetimeTestInstance2(NPP id, NPNetscapeFuncs *host_functions);
- ~NPObjectLifetimeTestInstance2();
+ virtual ~NPObjectLifetimeTestInstance2();
// NPAPI SetWindow handler.
virtual NPError SetWindow(NPWindow* pNPWindow);
@@ -58,7 +58,7 @@ class NPObjectDeletePluginInNPN_Evaluate : public PluginTest {
public:
// Constructor.
NPObjectDeletePluginInNPN_Evaluate(NPP id, NPNetscapeFuncs *host_functions);
- ~NPObjectDeletePluginInNPN_Evaluate();
+ virtual ~NPObjectDeletePluginInNPN_Evaluate();
// NPAPI SetWindow handler.
virtual NPError SetWindow(NPWindow* pNPWindow);
diff --git a/webkit/plugins/npapi/test/plugin_thread_async_call_test.h b/webkit/plugins/npapi/test/plugin_thread_async_call_test.h
index 2980dbc..6962276 100644
--- a/webkit/plugins/npapi/test/plugin_thread_async_call_test.h
+++ b/webkit/plugins/npapi/test/plugin_thread_async_call_test.h
@@ -18,7 +18,7 @@ namespace NPAPIClient {
class PluginThreadAsyncCallTest : public PluginTest {
public:
PluginThreadAsyncCallTest(NPP id, NPNetscapeFuncs *host_functions);
- ~PluginThreadAsyncCallTest();
+ virtual ~PluginThreadAsyncCallTest();
virtual NPError New(uint16 mode, int16 argc, const char* argn[],
const char* argv[], NPSavedData* saved);
diff --git a/webkit/plugins/npapi/webplugin_delegate_impl.h b/webkit/plugins/npapi/webplugin_delegate_impl.h
index 039bb23..b5156e3 100644
--- a/webkit/plugins/npapi/webplugin_delegate_impl.h
+++ b/webkit/plugins/npapi/webplugin_delegate_impl.h
@@ -201,7 +201,7 @@ class WebPluginDelegateImpl : public WebPluginDelegate {
WebPluginDelegateImpl(gfx::PluginWindowHandle containing_view,
PluginInstance *instance);
- ~WebPluginDelegateImpl();
+ virtual ~WebPluginDelegateImpl();
// Called by Initialize() for platform-specific initialization.
// If this returns false, the plugin shouldn't be started--see Initialize().
diff --git a/webkit/plugins/ppapi/ppb_audio_impl.h b/webkit/plugins/ppapi/ppb_audio_impl.h
index 201193f..060b8bf 100644
--- a/webkit/plugins/ppapi/ppb_audio_impl.h
+++ b/webkit/plugins/ppapi/ppb_audio_impl.h
@@ -31,7 +31,7 @@ class PPB_AudioConfig_Impl : public Resource,
public:
// Note that you must call Init (on AudioConfigImpl) before using this class.
PPB_AudioConfig_Impl(PluginInstance* instance);
- ~PPB_AudioConfig_Impl();
+ virtual ~PPB_AudioConfig_Impl();
// ResourceObjectBase overrides.
virtual ::ppapi::thunk::PPB_AudioConfig_API* AsAudioConfig_API() OVERRIDE;