RefCounted types should not have public destructors, webkit/ edition

BUG=123295
TEST=it compiles


Review URL: https://chromiumcodereview.appspot.com/10416004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140265 0039d316-1c4b-4281-b951-d872f2087c98

4 files changed, 13 insertions, 4 deletions

diff --git a/webkit/plugins/npapi/webplugin.h b/webkit/plugins/npapi/webplugin.h
index 4c5d41c..a7d86cf 100644
--- a/webkit/plugins/npapi/webplugin.h
+++ b/webkit/plugins/npapi/webplugin.h
@@ -176,6 +176,7 @@ class WebPlugin {
 class WebPluginResourceClient {
  public:
   virtual ~WebPluginResourceClient() {}
+
   virtual void WillSendRequest(const GURL& url, int http_status_code) = 0;
   // The request_is_seekable parameter indicates whether byte range requests
   // can be issued for the underlying stream.
diff --git a/webkit/plugins/npapi/webplugin_page_delegate.h b/webkit/plugins/npapi/webplugin_page_delegate.h
index 496bd6f..ec4b34a 100644
--- a/webkit/plugins/npapi/webplugin_page_delegate.h
+++ b/webkit/plugins/npapi/webplugin_page_delegate.h
@@ -60,6 +60,9 @@ class WebPluginPageDelegate {
 
   // The WebCookieJar to use for this plugin.
   virtual WebKit::WebCookieJar* GetCookieJar() = 0;
+
+ protected:
+  virtual ~WebPluginPageDelegate() {}
 };
 
 }  // namespace npapi
diff --git a/webkit/plugins/ppapi/fullscreen_container.h b/webkit/plugins/ppapi/fullscreen_container.h
index f8d4356..88500cd 100644
--- a/webkit/plugins/ppapi/fullscreen_container.h
+++ b/webkit/plugins/ppapi/fullscreen_container.h
@@ -21,8 +21,6 @@ namespace ppapi {
 // plugins, that only handles painting.
 class FullscreenContainer {
  public:
-  virtual ~FullscreenContainer() {}
-
   // Invalidates the full plugin region.
   virtual void Invalidate() = 0;
 
@@ -43,6 +41,9 @@ class FullscreenContainer {
 
   // The returned object is owned by FullscreenContainer.
   virtual MouseLockDispatcher* GetMouseLockDispatcher() = 0;
+
+ protected:
+  virtual ~FullscreenContainer() {}
 };
 
 }  // namespace ppapi
diff --git a/webkit/plugins/ppapi/plugin_delegate.h b/webkit/plugins/ppapi/plugin_delegate.h
index c9bf986..1908a53 100644
--- a/webkit/plugins/ppapi/plugin_delegate.h
+++ b/webkit/plugins/ppapi/plugin_delegate.h
@@ -282,10 +282,14 @@ class PluginDelegate {
   class PlatformVideoCapture : public media::VideoCapture,
                                public base::RefCounted<PlatformVideoCapture> {
    public:
-    virtual ~PlatformVideoCapture() {}
-
     // Detaches the event handler and stops sending notifications to it.
     virtual void DetachEventHandler() = 0;
+
+   protected:
+    virtual ~PlatformVideoCapture() {}
+
+   private:
+    friend class base::RefCounted<PlatformVideoCapture>;
   };
 
   // Provides access to the ppapi broker.