diff options
| author | ager@google.com <ager@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-07 12:46:05 +0000 |
|---|---|---|
| committer | ager@google.com <ager@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-07 12:46:05 +0000 |
| commit | 3e965a912eb059d826656622c12b0cb2ab42aa88 (patch) | |
| tree | 5046bb3d294b626e5ea41862ef46bcdcaa041e84 /webkit/port/page | |
| parent | 8eb9e9f3027704f7337c13c522e4b8c0941e086e (diff) | |
| download | chromium_src-3e965a912eb059d826656622c12b0cb2ab42aa88.zip chromium_src-3e965a912eb059d826656622c12b0cb2ab42aa88.tar.gz chromium_src-3e965a912eb059d826656622c12b0cb2ab42aa88.tar.bz2 | |
Disallow shadowing of top since shadowing top can break frame-busting
code.
Also, make sure that top, window, location, and location.href are not
deletable.
I had to fix a couple of layout tests that rely on top being shadowable.
Review URL: http://codereview.chromium.org/9506
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4984 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/port/page')
| -rw-r--r-- | webkit/port/page/DOMWindow.idl | 6 | ||||
| -rw-r--r-- | webkit/port/page/Location.idl | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/webkit/port/page/DOMWindow.idl b/webkit/port/page/DOMWindow.idl index a667251..2b4c483 100644 --- a/webkit/port/page/DOMWindow.idl +++ b/webkit/port/page/DOMWindow.idl @@ -52,7 +52,7 @@ module window { attribute [Replaceable] BarInfo toolbar; attribute [Replaceable] Navigator navigator; attribute [Replaceable, v8referenceattr=navigator] Navigator clientInformation; - attribute [DoNotCheckDomainSecurity, CustomSetter, v8DisallowShadowing] Location location; + attribute [DoNotCheckDomainSecurity, CustomSetter, DontDelete, v8DisallowShadowing] Location location; DOMSelection getSelection(); @@ -116,7 +116,7 @@ module window { // Self referential attributes attribute [Replaceable, DoNotCheckDomainSecurityOnGet] DOMWindow self; - readonly attribute [DoNotCheckDomainSecurity, v8DisallowShadowing] DOMWindow window; + readonly attribute [DoNotCheckDomainSecurity, DontDelete, v8DisallowShadowing] DOMWindow window; attribute [Replaceable, DoNotCheckDomainSecurityOnGet] DOMWindow frames; #if defined(V8_BINDING) @@ -125,7 +125,7 @@ module window { attribute [Replaceable, DoNotCheckDomainSecurityOnGet] DOMWindow opener; #endif attribute [Replaceable, DoNotCheckDomainSecurity] DOMWindow parent; - attribute [Replaceable, DoNotCheckDomainSecurity] DOMWindow top; + readonly attribute [DoNotCheckDomainSecurity, DontDelete, v8DisallowShadowing] DOMWindow top; // DOM Level 2 AbstractView Interface readonly attribute Document document; diff --git a/webkit/port/page/Location.idl b/webkit/port/page/Location.idl index e33a694..5432208 100644 --- a/webkit/port/page/Location.idl +++ b/webkit/port/page/Location.idl @@ -7,7 +7,7 @@ module core { attribute DOMString hash; attribute DOMString host; attribute DOMString hostname; - attribute [DoNotCheckDomainSecurityOnSet, v8DisallowShadowing] DOMString href; + attribute [DoNotCheckDomainSecurityOnSet, DontDelete, v8DisallowShadowing] DOMString href; attribute DOMString pathname; attribute DOMString port; attribute DOMString protocol; |