diff options
| author | tc@google.com <tc@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-11 00:35:27 +0000 |
|---|---|---|
| committer | tc@google.com <tc@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-11 00:35:27 +0000 |
| commit | 2255ea5ac77019d393c7776b387385565a9d3087 (patch) | |
| tree | 0ec499618c45c8eb841f768d6bde9ff9049dd368 /webkit/port/page | |
| parent | d960ba465f0513bf56d1e5317a9c7194da8306b5 (diff) | |
| download | chromium_src-2255ea5ac77019d393c7776b387385565a9d3087.zip chromium_src-2255ea5ac77019d393c7776b387385565a9d3087.tar.gz chromium_src-2255ea5ac77019d393c7776b387385565a9d3087.tar.bz2 | |
enable v8bindings warnings
Make warnings fatal in V8Bindings.
Review URL: http://codereview.chromium.org/7044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3263 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/port/page')
| -rw-r--r-- | webkit/port/page/inspector/InspectorController.cpp | 17 |
1 files changed, 4 insertions, 13 deletions
diff --git a/webkit/port/page/inspector/InspectorController.cpp b/webkit/port/page/inspector/InspectorController.cpp index 52dfab9..7aa0a44 100644 --- a/webkit/port/page/inspector/InspectorController.cpp +++ b/webkit/port/page/inspector/InspectorController.cpp @@ -82,7 +82,7 @@ namespace WebCore { // Maximum size of the console message cache. -static const int MAX_CONSOLE_MESSAGES = 250; +static const size_t MAX_CONSOLE_MESSAGES = 250; namespace bug1228513 { // TODO(ericroman): Temporary hacks to help diagnose http://b/1228513 @@ -277,6 +277,8 @@ struct InspectorResource : public RefCounted<InspectorResource> { } break; #endif + default: + break; } } @@ -576,6 +578,7 @@ InspectorController::InspectorController(Page* page, InspectorClient* client) // to start the RefCount at 0. RefCounted<InspectorController>(0) , m_bug1228513_inspectorState(bug1228513::VALID) + , m_trackResources(false) , m_inspectedPage(page) , m_client(client) , m_page(0) @@ -585,7 +588,6 @@ InspectorController::InspectorController(Page* page, InspectorClient* client) , m_recordingUserInitiatedProfile(false) , m_showAfterVisible(ElementsPanel) , m_nextIdentifier(-2) - , m_trackResources(false) , m_groupLevel(0) { ASSERT_ARG(page, page); @@ -641,17 +643,6 @@ String InspectorController::localizedStringsURL() return m_client->localizedStringsURL(); } -// Trying to inspect something in a frame with JavaScript disabled would later lead to -// crashes trying to create JavaScript wrappers. Some day we could fix this issue, but -// for now prevent crashes here by never targeting a node in such a frame. -static bool canPassNodeToJavaScript(Node* node) -{ - if (!node) - return false; - Frame* frame = node->document()->frame(); - return frame && frame->script()->isEnabled(); -} - void InspectorController::inspect(Node* node) { if (!node || !enabled()) |