diff options
| author | shess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-23 17:07:20 +0000 |
|---|---|---|
| committer | shess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-23 17:07:20 +0000 |
| commit | 9fe37555ac558799ab41508e8f654c87c704ba07 (patch) | |
| tree | a3056f6d3bafbf830b6c4fd896338ebb5332e241 /webkit/quota | |
| parent | b20ad84d73015b7b3fa6a3fd9051fbadd24a4281 (diff) | |
| download | chromium_src-9fe37555ac558799ab41508e8f654c87c704ba07.zip chromium_src-9fe37555ac558799ab41508e8f654c87c704ba07.tar.gz chromium_src-9fe37555ac558799ab41508e8f654c87c704ba07.tar.bz2 | |
[sql] WARN_UNUSED_RESULT on Execute().
Goal is to encourage callers to handle errors, especially in cases
like schema changes, where dropped errors can result in broken
databases.
Many CREATE INDEX calls where ignoring errors rather than checking if
the index already existed before creating it. Recoded those to CREATE
INDEX IF NOT EXISTS, which is for exactly this purpose.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9005036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115725 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/quota')
| -rw-r--r-- | webkit/quota/quota_database_unittest.cc | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/webkit/quota/quota_database_unittest.cc b/webkit/quota/quota_database_unittest.cc index 7045f7f..a653e32 100644 --- a/webkit/quota/quota_database_unittest.cc +++ b/webkit/quota/quota_database_unittest.cc @@ -417,8 +417,7 @@ class QuotaDatabaseTest : public testing::Test { bool OpenDatabase(sql::Connection* db, const FilePath& kDbFile) { if (kDbFile.empty()) { - db->OpenInMemory(); - return true; + return db->OpenInMemory(); } if (!file_util::CreateDirectory(kDbFile.DirName())) return false; |