diff options
| author | ojan@chromium.org <ojan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-01 21:01:49 +0000 |
|---|---|---|
| committer | ojan@chromium.org <ojan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-01 21:01:49 +0000 |
| commit | d728d7a1fcb715bd468597e9d7be169c3c6e7236 (patch) | |
| tree | 31db2b03264933b4add951f8bc1e0d188c976f90 /webkit/tools/layout_tests/dashboards/dashboard_base.js | |
| parent | 95ed7f6967a53e19aaa1027bf0bec4f7bef4886c (diff) | |
| download | chromium_src-d728d7a1fcb715bd468597e9d7be169c3c6e7236.zip chromium_src-d728d7a1fcb715bd468597e9d7be169c3c6e7236.tar.gz chromium_src-d728d7a1fcb715bd468597e9d7be169c3c6e7236.tar.bz2 | |
Fix broken sorting in the dashboard. The local variable 'key'
was overriding the key variable in the function arguments. :(
Review URL: http://codereview.chromium.org/255045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27766 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/tools/layout_tests/dashboards/dashboard_base.js')
| -rw-r--r-- | webkit/tools/layout_tests/dashboards/dashboard_base.js | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/webkit/tools/layout_tests/dashboards/dashboard_base.js b/webkit/tools/layout_tests/dashboards/dashboard_base.js index 1ead327..b752726 100644 --- a/webkit/tools/layout_tests/dashboards/dashboard_base.js +++ b/webkit/tools/layout_tests/dashboards/dashboard_base.js @@ -272,19 +272,13 @@ function handleLocationChange() { /** * Sets the page state. Takes varargs of key, value pairs. - * - * @return list of keys modified */ -function setQueryParameter(key, value) { - var keys = []; +function setQueryParameter(var_args) { for (var i = 0; i < arguments.length; i += 2) { - var key = arguments[i]; - keys.push(key); - currentState[key] = arguments[i + 1]; + currentState[arguments[i]] = arguments[i + 1]; } window.location.replace(getPermaLinkURL()); saveStoredWindowLocation(); - return keys; } function getPermaLinkURL() { |