diff options
author | jparent@chromium.org <jparent@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-21 21:55:59 +0000 |
---|---|---|
committer | jparent@chromium.org <jparent@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-21 21:55:59 +0000 |
commit | da0c4d3a7e0c37bfc71d2cd793f9153108c27393 (patch) | |
tree | 19a27027c92dafb374d6119976ed6e2fc8c073b8 /webkit/tools/layout_tests/flakiness_dashboard.html | |
parent | 0450b1717b8f1dac96927b795dc1af15b6e56788 (diff) | |
download | chromium_src-da0c4d3a7e0c37bfc71d2cd793f9153108c27393.zip chromium_src-da0c4d3a7e0c37bfc71d2cd793f9153108c27393.tar.gz chromium_src-da0c4d3a7e0c37bfc71d2cd793f9153108c27393.tar.bz2 |
Update layout test flakiness dashboard to hide tests that are matching their expectations by passing for at least as many runs as are showing.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/209056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26745 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/tools/layout_tests/flakiness_dashboard.html')
-rw-r--r-- | webkit/tools/layout_tests/flakiness_dashboard.html | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/webkit/tools/layout_tests/flakiness_dashboard.html b/webkit/tools/layout_tests/flakiness_dashboard.html index 70f7f9f..fe45eb0 100644 --- a/webkit/tools/layout_tests/flakiness_dashboard.html +++ b/webkit/tools/layout_tests/flakiness_dashboard.html @@ -915,6 +915,15 @@ } /** + * Returns whether the test has passed continuously for at + * least as many runs as we are showing results for. + */ + function hasPassedInMaxRuns(testResult) { + var results = testResult.rawResults; + return results[0][1] == 'P' && results[0][0] >= currentState.maxResults; + } + + /** * Returns whether we should exclude test results from the test table. * Note that we never want to exclude tests when we're in the individual * tests view of the dashboard since the user is explicitly listing tests @@ -927,6 +936,11 @@ if (testResult.isWontFix && !currentState.showWontFix) return true; + if (hasPassedInMaxRuns(testResult)) { + // Hide tests that are passing. + return true; + } + if ((testResult.meetsExpectations || isFixedTest(testResult)) && !currentState.showCorrectExpectations) { // Only hide flaky tests that match their expectations if showFlaky |