summaryrefslogtreecommitdiffstats
path: root/webkit/tools/layout_tests
diff options
context:
space:
mode:
authoryuzo@chromium.org <yuzo@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-05-13 08:00:28 +0000
committeryuzo@chromium.org <yuzo@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-05-13 08:00:28 +0000
commitc7ad5905e4520681e437e743f6d7f0b2a924ba8e (patch)
treeea9093e4010bba110071ceb1870789e394f26a44 /webkit/tools/layout_tests
parentdf62a33c2a09b14c6ea45949d48827f24ed3ad42 (diff)
downloadchromium_src-c7ad5905e4520681e437e743f6d7f0b2a924ba8e.zip
chromium_src-c7ad5905e4520681e437e743f6d7f0b2a924ba8e.tar.gz
chromium_src-c7ad5905e4520681e437e743f6d7f0b2a924ba8e.tar.bz2
Make canary-webkit-revisions.py print failures, not limited to those of webkit_tests.
Now running the script for non-webkit canary bots makes sense. This addresses the first half of Bug 78538. (For the last half, see http://codereview.chromium.org/6993006/) Example: $ ./webkit/tools/layout_tests/canary-webkit-revisions.py "XP Tests (dbg)" "Vista Tests" Oldest revision to check: 86223 "XP Tests (dbg)" "Vista Tests" **** Failing revisions ***** The last run was at r86225 on "XP Tests (dbg)" and the following 1 tests failed compile failed **** Passing revisions ***** No passing runs on "XP Tests (dbg)" The last passing run was at r86223 on "Vista Tests" Passing revision range: r86223 - r86223 TEST=run the script manually BUG=78538 Check the canary builds up to the last-rolled WebKit revision. The script now examines the DEPS file to know the WebKit revision. This patch solves the last half of BUG 78538. TEST=run canary-webkit-revisions.py and observe. BUG=78538 Review URL: http://codereview.chromium.org/7004017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85249 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/tools/layout_tests')
-rwxr-xr-xwebkit/tools/layout_tests/canary-webkit-revisions.py10
1 files changed, 8 insertions, 2 deletions
diff --git a/webkit/tools/layout_tests/canary-webkit-revisions.py b/webkit/tools/layout_tests/canary-webkit-revisions.py
index 577fce9..6aa8029 100755
--- a/webkit/tools/layout_tests/canary-webkit-revisions.py
+++ b/webkit/tools/layout_tests/canary-webkit-revisions.py
@@ -104,13 +104,19 @@ def _BuilderUrlFor(builder, max_builds):
def _ExtractFailingTests(build):
"""Extracts failing test names from a build result entry JSON object."""
+ failing_tests = []
for step in build["steps"]:
if step["name"] == _WEBKIT_TESTS:
for text in step["text"]:
prefix = text.find(_TEST_PREFIX)
suffix = text.find(_TEST_SUFFIX)
if prefix != -1 and suffix != -1:
- return sorted(text[prefix + len(_TEST_PREFIX): suffix].split(","))
+ failing_tests += sorted(
+ text[prefix + len(_TEST_PREFIX): suffix].split(","))
+ elif "results" in step:
+ # Existence of "results" entry seems to mean failure.
+ failing_tests.append(" ".join(step["text"]))
+ return failing_tests
def _RetrieveBuildResult(builder, max_builds, oldest_revision_to_check):
@@ -147,7 +153,7 @@ def _RetrieveBuildResult(builder, max_builds, oldest_revision_to_check):
continue
if build["text"][1] == "successful":
succeeded = True
- elif not failing_tests and _WEBKIT_TESTS in build["text"][1:]:
+ elif not failing_tests:
failing_tests = _ExtractFailingTests(build)
revision = 0
if build["sourceStamp"]["branch"] == "trunk":