looking at test shell tests on mac:

- unforking TestShell::CreateNewWindow, all code must live in a platform's
  Initialize method instead (some tests rely on knowing what CreateNewWindow
  does). (mac had issues w/ this)
- Mac: make the code path for tests that forces down windows properly clean up
  the bits in the same way a trip through the event loop would.
- add a few more logs/checks in the mac code to catch issues.
Review URL: http://codereview.chromium.org/18166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8211 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 12 insertions, 0 deletions

diff --git a/webkit/tools/test_shell/test_shell.cc b/webkit/tools/test_shell/test_shell.cc
index 41d2140..3247022 100755
--- a/webkit/tools/test_shell/test_shell.cc
+++ b/webkit/tools/test_shell/test_shell.cc
@@ -168,6 +168,18 @@ TestShell::~TestShell() {
   }
 }
 
+bool TestShell::CreateNewWindow(const std::wstring& startingURL,
+                                TestShell** result) {
+  TestShell* shell = new TestShell();
+  bool rv = shell->Initialize(startingURL);
+  if (rv) {
+    if (result)
+      *result = shell;
+    TestShell::windowList()->push_back(shell->m_mainWnd);
+  }
+  return rv;
+}
+
 void TestShell::ShutdownTestShell() {
 #if defined(OS_WIN) || defined(OS_MACOSX)
     PlatformShutdown();