diff options
author | jianli@chromium.org <jianli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-30 23:20:46 +0000 |
---|---|---|
committer | jianli@chromium.org <jianli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-30 23:20:46 +0000 |
commit | 2da8d317072968241f986ffed0be477900831889 (patch) | |
tree | 761eedfabaaba837480c3604c0cfcf10e8d7d07c /webkit/tools/test_shell | |
parent | b9a0b1b39c5bcf551178cab7a2aa5f24d5afc929 (diff) | |
download | chromium_src-2da8d317072968241f986ffed0be477900831889.zip chromium_src-2da8d317072968241f986ffed0be477900831889.tar.gz chromium_src-2da8d317072968241f986ffed0be477900831889.tar.bz2 |
Reland changes to enable worker layout tests. Compared to last review (http://codereview.chromium.org/50045), the following changes are made:
1) Add chrome/test/worker/DEPS to address checkdeps error.
2) Change test_expectations.txt to skip some worker layout tests.
3) Add test_worker.vcproj to webkit.sln so that test_worker.dll can be built for WebKit build.
Review URL: http://codereview.chromium.org/56074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12822 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/tools/test_shell')
-rw-r--r-- | webkit/tools/test_shell/test_shell.gyp | 2 | ||||
-rw-r--r-- | webkit/tools/test_shell/test_shell.vcproj | 8 | ||||
-rw-r--r-- | webkit/tools/test_shell/test_shell_tests.vcproj | 8 | ||||
-rw-r--r-- | webkit/tools/test_shell/test_shell_webkit_init.h | 5 | ||||
-rwxr-xr-x | webkit/tools/test_shell/test_webview_delegate.cc | 11 | ||||
-rw-r--r-- | webkit/tools/test_shell/test_webview_delegate.h | 1 | ||||
-rw-r--r-- | webkit/tools/test_shell/test_webworker_helper.cc | 90 | ||||
-rw-r--r-- | webkit/tools/test_shell/test_webworker_helper.h | 53 |
8 files changed, 176 insertions, 2 deletions
diff --git a/webkit/tools/test_shell/test_shell.gyp b/webkit/tools/test_shell/test_shell.gyp index e6f3a1e..fa40326 100644 --- a/webkit/tools/test_shell/test_shell.gyp +++ b/webkit/tools/test_shell/test_shell.gyp @@ -65,6 +65,8 @@ 'test_webview_delegate.h', 'test_webview_delegate_gtk.cc', 'test_webview_delegate_win.cc', + 'test_webworker_helper.cc', + 'test_webworker_helper.h', 'text_input_controller.cc', 'text_input_controller.h', 'webview_host.h', diff --git a/webkit/tools/test_shell/test_shell.vcproj b/webkit/tools/test_shell/test_shell.vcproj index b4d6410..12d36f0 100644 --- a/webkit/tools/test_shell/test_shell.vcproj +++ b/webkit/tools/test_shell/test_shell.vcproj @@ -322,6 +322,14 @@ > </File> <File + RelativePath=".\test_webworker_helper.cc" + > + </File> + <File + RelativePath=".\test_webworker_helper.h" + > + </File> + <File RelativePath=".\text_input_controller.cc" > </File> diff --git a/webkit/tools/test_shell/test_shell_tests.vcproj b/webkit/tools/test_shell/test_shell_tests.vcproj index 4311ba6..77ac1ef 100644 --- a/webkit/tools/test_shell/test_shell_tests.vcproj +++ b/webkit/tools/test_shell/test_shell_tests.vcproj @@ -287,6 +287,14 @@ > </File> <File + RelativePath=".\test_webworker_helper.cc" + > + </File> + <File + RelativePath=".\test_webworker_helper.h" + > + </File> + <File RelativePath=".\text_input_controller.cc" > </File> diff --git a/webkit/tools/test_shell/test_shell_webkit_init.h b/webkit/tools/test_shell/test_shell_webkit_init.h index 6a87100..ac3dcfc 100644 --- a/webkit/tools/test_shell/test_shell_webkit_init.h +++ b/webkit/tools/test_shell/test_shell_webkit_init.h @@ -33,6 +33,7 @@ class TestShellWebKitInit : public webkit_glue::WebKitClientImpl { ASCIIToUTF16(webkit_glue::GetUIResourceProtocol())); WebKit::registerExtension(extensions_v8::GearsExtension::Get()); WebKit::registerExtension(extensions_v8::IntervalExtension::Get()); + WebKit::enableWebWorkers(); } ~TestShellWebKitInit() { @@ -42,10 +43,10 @@ class TestShellWebKitInit : public webkit_glue::WebKitClientImpl { virtual WebKit::WebMimeRegistry* mimeRegistry() { return &mime_registry_; } - + WebKit::WebClipboard* clipboard() { if (!clipboard_.get()) { - // Mock out clipboard calls in layout test mode so that tests don't mess + // Mock out clipboard calls in layout test mode so that tests don't mess // with each other's copies/pastes when running in parallel. if (TestShell::layout_test_mode()) { clipboard_.reset(new MockWebClipboardImpl()); diff --git a/webkit/tools/test_shell/test_webview_delegate.cc b/webkit/tools/test_shell/test_webview_delegate.cc index 2a39260..a2cf6c0 100755 --- a/webkit/tools/test_shell/test_webview_delegate.cc +++ b/webkit/tools/test_shell/test_webview_delegate.cc @@ -6,6 +6,8 @@ // as the WebViewDelegate for the TestShellWebHost. The host is expected to // have initialized a MessageLoop before these methods are called. +#include "config.h" + #include "webkit/tools/test_shell/test_webview_delegate.h" #include "base/file_util.h" @@ -29,6 +31,7 @@ #include "webkit/glue/window_open_disposition.h" #include "webkit/tools/test_shell/test_navigation_controller.h" #include "webkit/tools/test_shell/test_shell.h" +#include "webkit/tools/test_shell/test_webworker_helper.h" #if defined(OS_WIN) // TODO(port): make these files work everywhere. @@ -849,3 +852,11 @@ std::wstring TestWebViewDelegate::GetFrameDescription(WebFrame* webframe) { return L"frame (anonymous)"; } } + +WebWorker* TestWebViewDelegate::CreateWebWorker(WebWorkerClient* client) { +#if ENABLE(WORKERS) + return TestWebWorkerHelper::CreateWebWorker(client); +#else + return NULL; +#endif +} diff --git a/webkit/tools/test_shell/test_webview_delegate.h b/webkit/tools/test_shell/test_webview_delegate.h index c24eccc..1204ded 100644 --- a/webkit/tools/test_shell/test_webview_delegate.h +++ b/webkit/tools/test_shell/test_webview_delegate.h @@ -83,6 +83,7 @@ class TestWebViewDelegate : public base::RefCounted<TestWebViewDelegate>, const std::string& mime_type, const std::string& clsid, std::string* actual_mime_type); + virtual WebWorker* CreateWebWorker(WebWorkerClient* client); virtual void OpenURL(WebView* webview, const GURL& url, const GURL& referrer, diff --git a/webkit/tools/test_shell/test_webworker_helper.cc b/webkit/tools/test_shell/test_webworker_helper.cc new file mode 100644 index 0000000..c365a2b --- /dev/null +++ b/webkit/tools/test_shell/test_webworker_helper.cc @@ -0,0 +1,90 @@ +// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "config.h" +#include <wtf/MainThread.h> +#include <wtf/Threading.h> +#undef LOG + +#include "build/build_config.h" + +#include "webkit/tools/test_shell/test_webworker_helper.h" + +#include "base/logging.h" +#include "base/file_util.h" +#include "base/path_service.h" +#include "third_party/WebKit/WebKit/chromium/public/WebKit.h" +#include "webkit/glue/webworkerclient.h" + + +WebWorker* TestWebWorkerHelper::CreateWebWorker(WebWorkerClient* client) { + TestWebWorkerHelper* loader = new TestWebWorkerHelper(); + return loader->CreateWebWorker_(client, loader); +} + +TestWebWorkerHelper::TestWebWorkerHelper() : +#if defined(OS_WIN) + module_(NULL), +#endif + CreateWebWorker_(NULL) { + Load(); +} + +TestWebWorkerHelper::~TestWebWorkerHelper() { +} + +bool TestWebWorkerHelper::IsMainThread() const { + return WTF::isMainThread(); +} + +void TestWebWorkerHelper::DispatchToMainThread(WTF::MainThreadFunction* func, + void* context) { + return WTF::callOnMainThread(func, context); +} + +bool TestWebWorkerHelper::Load() { +#if defined(OS_WIN) + FilePath path; + PathService::Get(base::DIR_EXE, &path); + path = path.AppendASCII("test_worker.dll"); + + module_ = LoadLibrary(path.value().c_str()); + if (module_ == 0) + return false; + + CreateWebWorker_ = reinterpret_cast<CreateWebWorkerFunc> + (GetProcAddress(module_, "CreateWebWorker")); + if (!CreateWebWorker_) { + FreeLibrary(module_); + module_ = 0; + return false; + } + + return true; +#else + NOTIMPLEMENTED(); + return false; +#endif +} + +void TestWebWorkerHelper::Unload() { + // Since this is called from DLL, delay the unloading until it can be + // invoked from EXE. + return WTF::callOnMainThread(UnloadHelper, this); +} + +void TestWebWorkerHelper::UnloadHelper(void* param) { + TestWebWorkerHelper* this_ptr = static_cast<TestWebWorkerHelper*>(param); + +#if defined(OS_WIN) + if (this_ptr->module_) { + FreeLibrary(this_ptr->module_); + this_ptr->module_ = 0; + } +#else + NOTIMPLEMENTED(); +#endif + + delete this_ptr; +} diff --git a/webkit/tools/test_shell/test_webworker_helper.h b/webkit/tools/test_shell/test_webworker_helper.h new file mode 100644 index 0000000..0e6c2b0 --- /dev/null +++ b/webkit/tools/test_shell/test_webworker_helper.h @@ -0,0 +1,53 @@ +// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef WEBKIT_TOOLS_TEST_SHELL_TEST_WEBWORKER_HELPER_H__ +#define WEBKIT_TOOLS_TEST_SHELL_TEST_WEBWORKER_HELPER_H__ + +#include <vector> +#if defined(OS_WIN) +#include <windows.h> +#endif + +#include "base/basictypes.h" +#include "base/port.h" + +#include <wtf/MainThread.h> + +class TestWebWorkerHelper; +class WebWorker; +class WebWorkerClient; + +// Function to call in test_worker DLL. +typedef WebWorker* (API_CALL *CreateWebWorkerFunc)( + WebWorkerClient* webworker_client, + TestWebWorkerHelper* webworker_helper);; + +class TestWebWorkerHelper { + public: + static WebWorker* CreateWebWorker(WebWorkerClient* client); + + TestWebWorkerHelper(); + ~TestWebWorkerHelper(); + + virtual bool IsMainThread() const; + virtual void DispatchToMainThread(WTF::MainThreadFunction* func, + void* context); + virtual void Unload(); + + private: + bool Load(); + static void UnloadHelper(void* param); + +#if defined(OS_WIN) + // TODO(port): Remove ifdefs when we have portable replacement for HMODULE. + HMODULE module_; +#endif // defined(OS_WIN) + + CreateWebWorkerFunc CreateWebWorker_; + + DISALLOW_COPY_AND_ASSIGN(TestWebWorkerHelper); +}; + +#endif // WEBKIT_TOOLS_TEST_SHELL_TEST_WEBWORKER_HELPER_H__ |