summaryrefslogtreecommitdiffstats
path: root/webkit/tools/test_shell
diff options
context:
space:
mode:
authoradamk@chromium.org <adamk@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-05-19 23:39:56 +0000
committeradamk@chromium.org <adamk@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-05-19 23:39:56 +0000
commit483cad04e9efc1b42f8b2b5b118a95a5650d3c3e (patch)
tree9b36f45f614a08e6c81798bb093101181dec195c /webkit/tools/test_shell
parent048a1d02a9e9e42e63df1a26417d3f79494afb7c (diff)
downloadchromium_src-483cad04e9efc1b42f8b2b5b118a95a5650d3c3e.zip
chromium_src-483cad04e9efc1b42f8b2b5b118a95a5650d3c3e.tar.gz
chromium_src-483cad04e9efc1b42f8b2b5b118a95a5650d3c3e.tar.bz2
Use appropriate FileSystemOperations in "filesystem:" URLRequestJobs.
FileSystemURLRequestJob now calls GetMetadata(), while FileSystemDirURLRequestJob calls ReadDirectory(). With neither calling GetLocalPath(), the need for FileSystemURLRequestJobBase has disappeared, as has the need for FileSystemOperation::GetLocalPath and FileSystemCallbackDispatcher::DidGetLocalPath(). The only changes in behavior due to this patch are: - ReadDirectory is now called on the URL, so it will still work properly after the obsfuscated filesystem is in use. - FileSystemDirURLRequestJob has been fixed to show a directory header. This was somehow lost in the refactor to use FileSystemURLRequestJobBase. - The error codes for "file not found" are now always net::ERR_FILE_NOT_FOUND. R=ericu@chromium.org Review URL: http://codereview.chromium.org/7047013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86015 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/tools/test_shell')
-rw-r--r--webkit/tools/test_shell/simple_file_system.cc5
-rw-r--r--webkit/tools/test_shell/simple_file_writer.cc4
2 files changed, 0 insertions, 9 deletions
diff --git a/webkit/tools/test_shell/simple_file_system.cc b/webkit/tools/test_shell/simple_file_system.cc
index ebda9bc..77a7a21 100644
--- a/webkit/tools/test_shell/simple_file_system.cc
+++ b/webkit/tools/test_shell/simple_file_system.cc
@@ -64,11 +64,6 @@ class SimpleFileSystemCallbackDispatcher
callbacks_->didSucceed();
}
- // Callback to report information for a file.
- virtual void DidGetLocalPath(const FilePath& local_path) {
- NOTREACHED();
- }
-
virtual void DidReadMetadata(const base::PlatformFileInfo& info,
const FilePath& platform_path) {
DCHECK(file_system_);
diff --git a/webkit/tools/test_shell/simple_file_writer.cc b/webkit/tools/test_shell/simple_file_writer.cc
index bd9b282..657d247 100644
--- a/webkit/tools/test_shell/simple_file_writer.cc
+++ b/webkit/tools/test_shell/simple_file_writer.cc
@@ -96,10 +96,6 @@ class SimpleFileWriter::IOThreadProxy
proxy_->DidSucceed();
}
- virtual void DidGetLocalPath(const FilePath& local_path) {
- NOTREACHED();
- }
-
virtual void DidFail(base::PlatformFileError error_code) {
proxy_->DidFail(error_code);
}