summaryrefslogtreecommitdiffstats
path: root/webkit/tools/test_shell
diff options
context:
space:
mode:
authorevan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-07-01 23:19:02 +0000
committerevan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-07-01 23:19:02 +0000
commit8d19c7d3c2cced64a6e1dd22bc893cd5fe25eb2f (patch)
tree0a6a1df23fc78afc64a8b8c4382792a2f7c7a06d /webkit/tools/test_shell
parent5d48cfa886921a239ef130f9e0204c324510f3c9 (diff)
downloadchromium_src-8d19c7d3c2cced64a6e1dd22bc893cd5fe25eb2f.zip
chromium_src-8d19c7d3c2cced64a6e1dd22bc893cd5fe25eb2f.tar.gz
chromium_src-8d19c7d3c2cced64a6e1dd22bc893cd5fe25eb2f.tar.bz2
Deprecate more old filepath functions.
These still exist on Windows due to being used by the installer, but by moving them into the Windows-only block we prevent them from being used in new code. BUG=24672 Review URL: http://codereview.chromium.org/2861042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51453 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/tools/test_shell')
-rw-r--r--webkit/tools/test_shell/test_shell.cc3
-rw-r--r--webkit/tools/test_shell/test_webview_delegate.cc4
2 files changed, 4 insertions, 3 deletions
diff --git a/webkit/tools/test_shell/test_shell.cc b/webkit/tools/test_shell/test_shell.cc
index 62bacb2..6845a95 100644
--- a/webkit/tools/test_shell/test_shell.cc
+++ b/webkit/tools/test_shell/test_shell.cc
@@ -773,8 +773,7 @@ bool IsDefaultPluginEnabled() {
FilePath exe_path;
if (PathService::Get(base::FILE_EXE, &exe_path)) {
- std::wstring exe_name = file_util::GetFilenameFromPath(
- exe_path.ToWStringHack());
+ std::wstring exe_name = exe_path.BaseName().ToWStringHack();
if (StartsWith(exe_name, L"test_shell_tests", false))
return true;
}
diff --git a/webkit/tools/test_shell/test_webview_delegate.cc b/webkit/tools/test_shell/test_webview_delegate.cc
index 8c27c3a..cc5ced31 100644
--- a/webkit/tools/test_shell/test_webview_delegate.cc
+++ b/webkit/tools/test_shell/test_webview_delegate.cc
@@ -137,8 +137,10 @@ std::string UrlSuitableForTestResult(const std::string& url) {
if (url.empty() || std::string::npos == url.find("file://"))
return url;
+ // TODO: elsewhere in the codebase we use net::FormatUrl() for this.
std::string filename =
- WideToUTF8(file_util::GetFilenameFromPath(UTF8ToWide(url)));
+ WideToUTF8(FilePath::FromWStringHack(UTF8ToWide(url))
+ .BaseName().ToWStringHack());
if (filename.empty())
return "file:"; // A WebKit test has this in its expected output.
return filename;