diff options
| author | rkc@chromium.org <rkc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-17 18:21:01 +0000 |
|---|---|---|
| committer | rkc@chromium.org <rkc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-17 18:21:01 +0000 |
| commit | 5fa849fee72799cf6dd7cbce4d65a4d8bf68fda2 (patch) | |
| tree | 3f25b8944198e1e9ba47bcc174a636bf58291bd5 /webkit/tools | |
| parent | 2d06fd76d4e59c295327ca2bd4a696893f586d18 (diff) | |
| download | chromium_src-5fa849fee72799cf6dd7cbce4d65a4d8bf68fda2.zip chromium_src-5fa849fee72799cf6dd7cbce4d65a4d8bf68fda2.tar.gz chromium_src-5fa849fee72799cf6dd7cbce4d65a4d8bf68fda2.tar.bz2 | |
Merge 85652 - Fix for crash in feedback.
On sending the report, sometimes feedback seems to crash. It seems like the crash is happening in ClobberScreenshotSource, when we try to access tab_.
Right before we call ClobberScreenshotSource, we CloseTabContents on the tab_ object; this probably isn't crashing in the majority case since the browser completely unloads the tab async, allowing ClobberScreenshotSource enough time to access the still valid tab_ object.
There is no real reason to Clobber after the tab is closed, hence moving the call to before we actually close the tab and we're gauranteed to have a valid object in tab_
R=stevenjb@chromium.org,zelidrag@chromium.org
BUG=15253
TEST=There is no repro for this crash, so we'll have to see if this gets fixed once we push this out to users.
Review URL: http://codereview.chromium.org/7036013
TBR=rkc@chromium.org
Review URL: http://codereview.chromium.org/7039015
git-svn-id: svn://svn.chromium.org/chrome/branches/742/src@85655 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/tools')
0 files changed, 0 insertions, 0 deletions