summaryrefslogtreecommitdiffstats
path: root/webkit/tools
diff options
context:
space:
mode:
authorericu@google.com <ericu@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-28 22:26:50 +0000
committerericu@google.com <ericu@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-28 22:26:50 +0000
commitbacef3cbbc55efebb2573194d329eabac5f5c7e3 (patch)
treecaa96791f328bb36601bcb839e6544f3cfdf8290 /webkit/tools
parent748ce719f7594754695dfbd17b35618a58a5ffd1 (diff)
downloadchromium_src-bacef3cbbc55efebb2573194d329eabac5f5c7e3.zip
chromium_src-bacef3cbbc55efebb2573194d329eabac5f5c7e3.tar.gz
chromium_src-bacef3cbbc55efebb2573194d329eabac5f5c7e3.tar.bz2
Remove the path from PlatformFileInfo; it's cleaner just to pass it along as a
separate parameter, and not clutter up a base type. BUG:none TEST:none Review URL: http://codereview.chromium.org/6731033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79624 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/tools')
-rw-r--r--webkit/tools/test_shell/simple_file_system.cc5
-rw-r--r--webkit/tools/test_shell/simple_file_writer.cc9
2 files changed, 9 insertions, 5 deletions
diff --git a/webkit/tools/test_shell/simple_file_system.cc b/webkit/tools/test_shell/simple_file_system.cc
index 8fbc101..ecbc6d5 100644
--- a/webkit/tools/test_shell/simple_file_system.cc
+++ b/webkit/tools/test_shell/simple_file_system.cc
@@ -64,7 +64,8 @@ class SimpleFileSystemCallbackDispatcher
callbacks_->didSucceed();
}
- virtual void DidReadMetadata(const base::PlatformFileInfo& info) {
+ virtual void DidReadMetadata(const base::PlatformFileInfo& info,
+ const FilePath& platform_path) {
DCHECK(file_system_);
WebFileInfo web_file_info;
web_file_info.length = info.size;
@@ -72,7 +73,7 @@ class SimpleFileSystemCallbackDispatcher
web_file_info.type = info.is_directory ?
WebFileInfo::TypeDirectory : WebFileInfo::TypeFile;
web_file_info.platformPath =
- webkit_glue::FilePathToWebString(info.path);
+ webkit_glue::FilePathToWebString(platform_path);
callbacks_->didReadMetadata(web_file_info);
}
diff --git a/webkit/tools/test_shell/simple_file_writer.cc b/webkit/tools/test_shell/simple_file_writer.cc
index e245b63..9304978 100644
--- a/webkit/tools/test_shell/simple_file_writer.cc
+++ b/webkit/tools/test_shell/simple_file_writer.cc
@@ -104,7 +104,9 @@ class SimpleFileWriter::IOThreadProxy
proxy_->DidWrite(bytes, complete);
}
- virtual void DidReadMetadata(const base::PlatformFileInfo&) {
+ virtual void DidReadMetadata(
+ const base::PlatformFileInfo&,
+ const FilePath&) {
NOTREACHED();
}
@@ -114,8 +116,9 @@ class SimpleFileWriter::IOThreadProxy
NOTREACHED();
}
- virtual void DidOpenFileSystem(const std::string& name,
- const FilePath& root_path) {
+ virtual void DidOpenFileSystem(
+ const std::string& name,
+ const FilePath& root_path) {
NOTREACHED();
}