diff options
| author | ojan@chromium.org <ojan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-08 20:45:57 +0000 |
|---|---|---|
| committer | ojan@chromium.org <ojan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-08 20:45:57 +0000 |
| commit | c8cbecbafe2b506036c9a8f05344f3525bbb3db8 (patch) | |
| tree | b482eff9a525f245c19aea01a49a719b91aba686 /webkit/tools | |
| parent | ce76aa74b0bacbe93aa961a7df277e12cbe9f1c9 (diff) | |
| download | chromium_src-c8cbecbafe2b506036c9a8f05344f3525bbb3db8.zip chromium_src-c8cbecbafe2b506036c9a8f05344f3525bbb3db8.tar.gz chromium_src-c8cbecbafe2b506036c9a8f05344f3525bbb3db8.tar.bz2 | |
Add lint check that REBASELINE is not in test_expectations.txt.
REBASELINE lines should never get checked in. The linter is run
on precommit.
Review URL: http://codereview.chromium.org/271025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28441 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/tools')
| -rw-r--r-- | webkit/tools/layout_tests/layout_package/test_expectations.py | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/webkit/tools/layout_tests/layout_package/test_expectations.py b/webkit/tools/layout_tests/layout_package/test_expectations.py index b94650c..5f98d8d 100644 --- a/webkit/tools/layout_tests/layout_package/test_expectations.py +++ b/webkit/tools/layout_tests/layout_package/test_expectations.py @@ -234,6 +234,7 @@ class TestExpectationsFile: """ self._path = path + self._is_lint_mode = full_test_list is None self._full_test_list = full_test_list self._errors = [] self._non_fatal_errors = [] @@ -469,6 +470,10 @@ class TestExpectationsFile: self._AddError(lineno, 'Test cannot be both DEFER and WONTFIX.', test_and_expectations) + if self._is_lint_mode and 'rebaseline' in options: + self._AddError(lineno, 'REBASELINE should only be used for running' + 'rebaseline.py. Cannot be checked in.', test_and_expectations) + return True def _MatchPlatform(self, options): |