summaryrefslogtreecommitdiffstats
path: root/webkit/tools
diff options
context:
space:
mode:
authorsidchat@google.com <sidchat@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-02 21:42:55 +0000
committersidchat@google.com <sidchat@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-02 21:42:55 +0000
commite97cdd5e81a3f8c3bd735ab1e7d264c36c2c3870 (patch)
tree389fa3b1f1413f9cac12b97224abf067f0bb5d38 /webkit/tools
parenta63424d0df79fc6d6742b1670b15985a0acc2efe (diff)
downloadchromium_src-e97cdd5e81a3f8c3bd735ab1e7d264c36c2c3870.zip
chromium_src-e97cdd5e81a3f8c3bd735ab1e7d264c36c2c3870.tar.gz
chromium_src-e97cdd5e81a3f8c3bd735ab1e7d264c36c2c3870.tar.bz2
Rebaseline an SVG layout test. The difference is that we draw two additional one-pixel-wide black lines, one horizontal and one vertical, which occur on the top and left of the box respectively. This gives the box a 3-D appearance. After reviewing the SVG code, it seems we are doing the right thing; i.e., the code specifies to draw these lines with stroke-width="1" to give the 3-D appearance. I am thinking that in the original mac baseline, these lines are not prominent due to difference in Skia SVG line handling and shading.
Review URL: http://codereview.chromium.org/28321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10728 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/tools')
-rw-r--r--webkit/tools/layout_tests/test_lists/tests_fixable.txt3
1 files changed, 1 insertions, 2 deletions
diff --git a/webkit/tools/layout_tests/test_lists/tests_fixable.txt b/webkit/tools/layout_tests/test_lists/tests_fixable.txt
index 4780975..8e52fb9 100644
--- a/webkit/tools/layout_tests/test_lists/tests_fixable.txt
+++ b/webkit/tools/layout_tests/test_lists/tests_fixable.txt
@@ -330,6 +330,7 @@ LINUX : LayoutTests/svg/custom/deep-dynamic-updates.svg = FAIL CRASH
LINUX : LayoutTests/svg/W3C-SVG-1.1/animate-elem-33-t.svg = FAIL
LINUX : LayoutTests/svg/W3C-SVG-1.1/pservers-grad-17-b.svg = FAIL
LINUX : LayoutTests/svg/custom/gradient-stroke-width.svg = FAIL
+LINUX : LayoutTests/svg/custom/dominant-baseline-hanging.svg = FAIL
// For these two fast/frames tests it looks like the win baseline had some weird
// artifacts on the scrollbars on one of the frames, which has now been removed.
// This artifact does not exist on the mac baseline.
@@ -498,8 +499,6 @@ LINUX WIN : LayoutTests/svg/batik/text/textEffect3.svg = FAIL
// 2008/12/13 - This was FAIL but is now CRASH on WIN. See issue 6869.
LINUX WIN : LayoutTests/svg/carto.net/selectionlist.svg = FAIL CRASH
LayoutTests/svg/css/getComputedStyle-basic.xhtml = FAIL
-// Flaky on both release and debug.
-LINUX WIN : LayoutTests/svg/custom/dominant-baseline-hanging.svg = FAIL
LINUX WIN : LayoutTests/svg/custom/focus-ring.svg = FAIL
LINUX WIN : LayoutTests/svg/custom/image-small-width-height.svg = FAIL
// Our green is darker and we seem to be a pixel taller.