diff options
| author | scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-10 21:53:00 +0000 |
|---|---|---|
| committer | scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-10 21:53:00 +0000 |
| commit | 8fead9b6d8ec131f11d5fe638340cda8b6e1bb48 (patch) | |
| tree | 638e5f7c5e9c683e7d3dccba52c6b04e326d9d7d /webkit/tools | |
| parent | 10f92ad326ee8b42f2cdba4f4b471c516c18e281 (diff) | |
| download | chromium_src-8fead9b6d8ec131f11d5fe638340cda8b6e1bb48.zip chromium_src-8fead9b6d8ec131f11d5fe638340cda8b6e1bb48.tar.gz chromium_src-8fead9b6d8ec131f11d5fe638340cda8b6e1bb48.tar.bz2 | |
Removing --enable-video and instead relying on having DLLs present.
I measured a ~10ms startup regression when the DLLs are not present and a ~20ms
regression when the DLLs are present and loaded in render_process.cc.
Not sure how else to tackle this problem since we need these DLLs loaded before
the sandbox is engaged.
Review URL: http://codereview.chromium.org/63101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13542 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/tools')
| -rw-r--r-- | webkit/tools/test_shell/test_shell_main.cc | 2 | ||||
| -rw-r--r-- | webkit/tools/test_shell/test_shell_switches.cc | 3 | ||||
| -rw-r--r-- | webkit/tools/test_shell/test_shell_switches.h | 1 |
3 files changed, 1 insertions, 5 deletions
diff --git a/webkit/tools/test_shell/test_shell_main.cc b/webkit/tools/test_shell/test_shell_main.cc index 60ea705..d409d8e 100644 --- a/webkit/tools/test_shell/test_shell_main.cc +++ b/webkit/tools/test_shell/test_shell_main.cc @@ -237,7 +237,7 @@ int main(int argc, char* argv[]) { base::MemoryDebug::DumpAllMemoryInUse(); } - if (parsed_command_line.HasSwitch(test_shell::kEnableVideo)) { + if (false) { // TODO(scherkus): check for any DLL dependencies. webkit_glue::SetMediaPlayerAvailable(true); } diff --git a/webkit/tools/test_shell/test_shell_switches.cc b/webkit/tools/test_shell/test_shell_switches.cc index 04e65d0..0884929 100644 --- a/webkit/tools/test_shell/test_shell_switches.cc +++ b/webkit/tools/test_shell/test_shell_switches.cc @@ -64,9 +64,6 @@ const wchar_t kAllowScriptsToCloseWindows[] = L"allow-scripts-to-close-windows"; extern const wchar_t kCheckLayoutTestSystemDeps[] = L"check-layout-test-sys-deps"; -// Enable the media player by having this switch. -extern const wchar_t kEnableVideo[] = L"enable-video"; - // If set, we are running under GDB so allow a certain class of errors // to happen even if in layout test mode. extern const wchar_t kGDB[] = L"gdb"; diff --git a/webkit/tools/test_shell/test_shell_switches.h b/webkit/tools/test_shell/test_shell_switches.h index e23abbb..be995d1 100644 --- a/webkit/tools/test_shell/test_shell_switches.h +++ b/webkit/tools/test_shell/test_shell_switches.h @@ -28,7 +28,6 @@ extern const wchar_t kEnableFileCookies[]; extern const wchar_t kEnableTracing[]; extern const wchar_t kAllowScriptsToCloseWindows[]; extern const wchar_t kCheckLayoutTestSystemDeps[]; -extern const wchar_t kEnableVideo[]; extern const wchar_t kGDB[]; extern const wchar_t kProfiler[]; |