diff options
| author | epoger@google.com <epoger@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-13 17:40:20 +0000 |
|---|---|---|
| committer | epoger@google.com <epoger@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-13 17:40:20 +0000 |
| commit | 49ac7d99d2eac8182ed283cd069a739ff1d56f27 (patch) | |
| tree | 3f7f13edea039fc1095c59a5995c13f0e7d829d9 /webkit/tools | |
| parent | d506cacb14cf463567005a26df4c10326f158cf6 (diff) | |
| download | chromium_src-49ac7d99d2eac8182ed283cd069a739ff1d56f27.zip chromium_src-49ac7d99d2eac8182ed283cd069a739ff1d56f27.tar.gz chromium_src-49ac7d99d2eac8182ed283cd069a739ff1d56f27.tar.bz2 | |
new guidelines for use of chromium's test_expectations file
Review URL: https://chromiumcodereview.appspot.com/9665004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126417 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/tools')
| -rw-r--r-- | webkit/tools/layout_tests/test_expectations.txt | 33 |
1 files changed, 27 insertions, 6 deletions
diff --git a/webkit/tools/layout_tests/test_expectations.txt b/webkit/tools/layout_tests/test_expectations.txt index 044b686..03d2a3d 100644 --- a/webkit/tools/layout_tests/test_expectations.txt +++ b/webkit/tools/layout_tests/test_expectations.txt @@ -1,12 +1,33 @@ // This file should almost always be empty. Normally Chromium test expectations -// are found in +// are only put here temporarily, and moved to // src/third_party/WebKit/LayoutTests/platform/chromium/test_expectations.txt +// where they will remain until they are rebaselined. // -// Only add expectations here to temporarily suppress messages on the bots -// until the changes can be landed upstream. - -// PLEASE DO NOT LEAVE ENTRIES IN THIS FILE FOR MORE THAN 24 HRS. - +// +// If you are landing a Chromium CL that would break webkit layout tests, +// please follow these steps: +// +// 1. Add expected failures to the bottom of this file, and run your CL through +// various *_layout trybots. Confirm that the trybot results are green (any +// failures are masked by the expectations you added to this file). +// +// 2. BEFORE landing your Chromium CL, land a WebKit CL adding those same +// expected failures to +// src/third_party/WebKit/LayoutTests/platform/chromium/test_expectations.txt . +// +// 3. AFTER you have landed the WebKit test_expectations CL, you can land your +// Chromium CL. Be sure to include your expected failures in this file, so +// that other tip-of-tree Chromium developers will not be disturbed by your +// change. +// +// +// Every time Chromium's "WebKit Gardener" rolls the WebKit DEPS within +// Chromium, he will delete ALL expectations within this file. (By then, they +// will be redundant, because you already landed those same expectations in +// src/third_party/WebKit/LayoutTests/platform/chromium/test_expectations.txt . +// Right?) +// +// EVERYTHING BELOW THIS LINE WILL BE DELETED AT EVERY WEBKIT DEPS ROLL BUGYANGGUO LINUX X86_64 : fast/repaint/moving-shadow-on-container.html = TEXT BUGYANGGUO LINUX X86_64 : fast/repaint/moving-shadow-on-path.html = TEXT BUGYANGGUO LINUX X86_64 : svg/css/stars-with-shadow.html = TEXT |