diff options
author | scheib@chromium.org <scheib@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-06 20:30:09 +0000 |
---|---|---|
committer | scheib@chromium.org <scheib@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-06 20:30:09 +0000 |
commit | 5ae1f730fffdc5b06423a92acc8e004ce4b6bc64 (patch) | |
tree | 7aafbabace87609d656457813309c2fb691f2049 /webkit/tools | |
parent | ff24f49bedc612731ed5632391ce4325698ae8dc (diff) | |
download | chromium_src-5ae1f730fffdc5b06423a92acc8e004ce4b6bc64.zip chromium_src-5ae1f730fffdc5b06423a92acc8e004ce4b6bc64.tar.gz chromium_src-5ae1f730fffdc5b06423a92acc8e004ce4b6bc64.tar.bz2 |
Revert 84486 - Merge gpu_trace_event back into base/debug/trace_event.Initial land attempt at http://codereview.chromium.org/6551019/gpu_trace_event fork at http://codereview.chromium.org/6691013- gpu_trace_event renamed to base/debug/trace_event and modified as appropriate for base::debug- Unit Tests implemented for trace_event- gpu_common library removed (was added only for gpu_trace_event)- Existing calls to trace_event suffixed with _ETW to make ETW calls (see decisions and incremental plans at end of 6551019)- GPU trace calls renamed to new calls.- Tracing switch removed from test_shell, as linux log file support removed.BUG=79509TEST=trace_event_win_unittest and about:gpuCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=84284Review URL: http://codereview.chromium.org/6862002
TBR=scheib@chromium.org
Review URL: http://codereview.chromium.org/6955006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84494 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/tools')
-rw-r--r-- | webkit/tools/test_shell/test_shell_main.cc | 3 | ||||
-rw-r--r-- | webkit/tools/test_shell/test_shell_switches.cc | 5 | ||||
-rw-r--r-- | webkit/tools/test_shell/test_shell_switches.h | 3 | ||||
-rw-r--r-- | webkit/tools/test_shell/test_shell_win.cc | 2 | ||||
-rw-r--r-- | webkit/tools/test_shell/test_webview_delegate.cc | 6 |
5 files changed, 13 insertions, 6 deletions
diff --git a/webkit/tools/test_shell/test_shell_main.cc b/webkit/tools/test_shell/test_shell_main.cc index e107b6a..49ed62b 100644 --- a/webkit/tools/test_shell/test_shell_main.cc +++ b/webkit/tools/test_shell/test_shell_main.cc @@ -158,6 +158,9 @@ int main(int argc, char* argv[]) { platform.SuppressErrorReporting(); } + if (parsed_command_line.HasSwitch(test_shell::kEnableTracing)) + base::debug::TraceLog::StartTracing(); + net::HttpCache::Mode cache_mode = net::HttpCache::NORMAL; // This is a special mode where JS helps the browser implement diff --git a/webkit/tools/test_shell/test_shell_switches.cc b/webkit/tools/test_shell/test_shell_switches.cc index fd88861..713aaed 100644 --- a/webkit/tools/test_shell/test_shell_switches.cc +++ b/webkit/tools/test_shell/test_shell_switches.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -65,6 +65,9 @@ const char kDebugMemoryInUse[] = "debug-memory-in-use"; // Enable cookies on the file:// scheme. --layout-tests also enables this. const char kEnableFileCookies[] = "enable-file-cookies"; +// Enable tracing events (see base/debug/trace_event.h) +const char kEnableTracing[] = "enable-tracing"; + // Allow scripts to close windows in all cases. const char kAllowScriptsToCloseWindows[] = "allow-scripts-to-close-windows"; diff --git a/webkit/tools/test_shell/test_shell_switches.h b/webkit/tools/test_shell/test_shell_switches.h index 884b66625..dd4d451 100644 --- a/webkit/tools/test_shell/test_shell_switches.h +++ b/webkit/tools/test_shell/test_shell_switches.h @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -27,6 +27,7 @@ extern const char kDumpStatsTable[]; extern const char kCacheDir[]; extern const char kDebugMemoryInUse[]; extern const char kEnableFileCookies[]; +extern const char kEnableTracing[]; extern const char kAllowScriptsToCloseWindows[]; extern const char kCheckLayoutTestSystemDeps[]; extern const char kGDB[]; diff --git a/webkit/tools/test_shell/test_shell_win.cc b/webkit/tools/test_shell/test_shell_win.cc index 8245b6e..6b4d00f7 100644 --- a/webkit/tools/test_shell/test_shell_win.cc +++ b/webkit/tools/test_shell/test_shell_win.cc @@ -479,7 +479,7 @@ void TestShell::LoadURLForFrame(const GURL& url, if (!url.is_valid()) return; - TRACE_EVENT_BEGIN_ETW("url.load", this, url.spec()); + TRACE_EVENT_BEGIN("url.load", this, url.spec()); if (IsSVGTestURL(url)) { SizeToSVG(); diff --git a/webkit/tools/test_shell/test_webview_delegate.cc b/webkit/tools/test_shell/test_webview_delegate.cc index 4fe60e8..745b2d0 100644 --- a/webkit/tools/test_shell/test_webview_delegate.cc +++ b/webkit/tools/test_shell/test_webview_delegate.cc @@ -819,7 +819,7 @@ void TestWebViewDelegate::didFailLoad( } void TestWebViewDelegate::didFinishLoad(WebFrame* frame) { - TRACE_EVENT_END_ETW("frame.load", this, frame->url().spec()); + TRACE_EVENT_END("frame.load", this, frame->url().spec()); UpdateAddressBar(frame->view()); LocationChangeDone(frame); } @@ -877,7 +877,7 @@ void TestWebViewDelegate::willSendRequest( header != clear_headers_.end(); ++header) request.clearHTTPHeaderField(WebString::fromUTF8(*header)); - TRACE_EVENT_BEGIN_ETW("url.load", identifier, request_url); + TRACE_EVENT_BEGIN("url.load", identifier, request_url); // Set the new substituted URL. request.setURL(GURL(TestShell::RewriteLocalUrl(request_url))); } @@ -888,7 +888,7 @@ void TestWebViewDelegate::didReceiveResponse( void TestWebViewDelegate::didFinishResourceLoad( WebFrame* frame, unsigned identifier) { - TRACE_EVENT_END_ETW("url.load", identifier, ""); + TRACE_EVENT_END("url.load", identifier, ""); resource_identifier_map_.erase(identifier); } |