summaryrefslogtreecommitdiffstats
path: root/webkit
diff options
context:
space:
mode:
authormbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-01-14 01:02:53 +0000
committermbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-01-14 01:02:53 +0000
commitc40acc381fce1ac7f58975d45bd88e26a5e4a973 (patch)
treec7ad6b6abbf1ce022f2f74e6ae70d941072cacde /webkit
parent9263a4957be27c1c3e0aec8170b6f161619300ca (diff)
downloadchromium_src-c40acc381fce1ac7f58975d45bd88e26a5e4a973.zip
chromium_src-c40acc381fce1ac7f58975d45bd88e26a5e4a973.tar.gz
chromium_src-c40acc381fce1ac7f58975d45bd88e26a5e4a973.tar.bz2
Rename CloseIdleConnections -> CloseCurrentConnections.
This method is (and was) just for debugging; while it was closing idle connections, that was not aggressive enough; the benchmark needs to close all connections, not just the idle ones. To ensure connections are abandoned, create a new pool; leaving the old pool to languish as any pending sockets die. BUG=none TEST=none Review URL: http://codereview.chromium.org/549031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36208 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
-rw-r--r--webkit/extensions/v8/benchmarking_extension.cc2
-rw-r--r--webkit/glue/webkit_glue.h4
-rw-r--r--webkit/tools/test_shell/test_shell.cc2
3 files changed, 4 insertions, 4 deletions
diff --git a/webkit/extensions/v8/benchmarking_extension.cc b/webkit/extensions/v8/benchmarking_extension.cc
index 4823718..0583f70 100644
--- a/webkit/extensions/v8/benchmarking_extension.cc
+++ b/webkit/extensions/v8/benchmarking_extension.cc
@@ -49,7 +49,7 @@ class BenchmarkingWrapper : public v8::Extension {
}
static v8::Handle<v8::Value> CloseConnections(const v8::Arguments& args) {
- webkit_glue::CloseIdleConnections();
+ webkit_glue::CloseCurrentConnections();
return v8::Undefined();
}
diff --git a/webkit/glue/webkit_glue.h b/webkit/glue/webkit_glue.h
index c46e094a..026b47f 100644
--- a/webkit/glue/webkit_glue.h
+++ b/webkit/glue/webkit_glue.h
@@ -225,8 +225,8 @@ bool FindProxyForUrl(const GURL& url, std::string* proxy_list);
// the form language-country (e.g., en-US or pt-BR).
std::wstring GetWebKitLocale();
-// Close idle connections. Used for debugging.
-void CloseIdleConnections();
+// Close current connections. Used for debugging.
+void CloseCurrentConnections();
// Enable or disable the disk cache. Used for debugging.
void SetCacheMode(bool enabled);
diff --git a/webkit/tools/test_shell/test_shell.cc b/webkit/tools/test_shell/test_shell.cc
index 1745f37..c93d814 100644
--- a/webkit/tools/test_shell/test_shell.cc
+++ b/webkit/tools/test_shell/test_shell.cc
@@ -753,7 +753,7 @@ std::wstring GetWebKitLocale() {
return L"en-US";
}
-void CloseIdleConnections() {
+void CloseCurrentConnections() {
// Used in benchmarking, Ignored for test_shell.
}