diff options
author | ojan@chromium.org <ojan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-17 00:38:30 +0000 |
---|---|---|
committer | ojan@chromium.org <ojan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-17 00:38:30 +0000 |
commit | 3697e9d56b2fc863506524c4515aa380335755d6 (patch) | |
tree | a814b78d7a0b81a0229e26032c0a3205c590926b /webkit | |
parent | a0d87d1e815a79a9223aff80e738bbd2fc5dfd0e (diff) | |
download | chromium_src-3697e9d56b2fc863506524c4515aa380335755d6.zip chromium_src-3697e9d56b2fc863506524c4515aa380335755d6.tar.gz chromium_src-3697e9d56b2fc863506524c4515aa380335755d6.tar.bz2 |
Show diffs of expected/actual results when they are available.
Review URL: http://codereview.chromium.org/399018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32134 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
-rw-r--r-- | webkit/tools/layout_tests/dashboards/dashboard_base.js | 4 | ||||
-rw-r--r-- | webkit/tools/layout_tests/flakiness_dashboard.html | 18 |
2 files changed, 18 insertions, 4 deletions
diff --git a/webkit/tools/layout_tests/dashboards/dashboard_base.js b/webkit/tools/layout_tests/dashboards/dashboard_base.js index 7ec9eef..803b6b7 100644 --- a/webkit/tools/layout_tests/dashboards/dashboard_base.js +++ b/webkit/tools/layout_tests/dashboards/dashboard_base.js @@ -120,6 +120,10 @@ function startsWith(a, b) { return a.indexOf(b) == 0; } +function endsWidth(a, b) { + return a.lastIndexOf(b) == a.length - b.length; +} + function isValidName(str) { return str.match(/[A-Za-z0-9\-\_,]/); } diff --git a/webkit/tools/layout_tests/flakiness_dashboard.html b/webkit/tools/layout_tests/flakiness_dashboard.html index 1eb9cfc..fb5dcc6 100644 --- a/webkit/tools/layout_tests/flakiness_dashboard.html +++ b/webkit/tools/layout_tests/flakiness_dashboard.html @@ -1508,8 +1508,8 @@ return html + '<div class=expectations test=' + test + '><div>' + getLinkHTMLToToggleState('showExpectations', 'expectations') + ' | ' + getLinkHTMLToToggleState('showLargeExpectations', 'large thumbnails') + - ' | <b>Only shows actual results from the most recent run on each ' + - 'bot.</b></div></div>'; + ' | <b>Only shows actual results/diffs from the most recent *failure*' + + ' on each bot.</b></div></div>'; } function getExpectationsContainer(expectationsContainers, parentContainer, @@ -1692,7 +1692,17 @@ var innerHTML; if (builder) { - innerHTML = 'ACTUAL RESULTS: ' + builder; + var resultsType; + if (endsWidth(path, '-stack.txt')) { + resultsType = 'STACKTRACE'; + } else if (endsWidth(path, '-actual.txt') || + endsWidth(path, '-actual.checksum') || + endsWidth(path, '-actual.png')) { + resultsType = 'ACTUAL RESULTS'; + } else { + resultsType = 'DIFF'; + } + innerHTML = resultsType + ': ' + builder; } else if (platform == LAYOUT_TESTS_PREFIX) { var parts = path.split('/'); innerHTML = parts[parts.length - 1]; @@ -1757,7 +1767,7 @@ } var actualResultSuffixes = ['-actual.txt', '-actual.checksum', - '-actual.png', '-stack.png']; + '-actual.png', '-stack.txt', '-diff.txt', '-wdiff.html', '-diff.png']; for (var builder in builders) { var actualResultsBase = |