Basic GetScreenInfo implementation for gtk.

Review URL: http://codereview.chromium.org/10754

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5499 0039d316-1c4b-4281-b951-d872f2087c98

6 files changed, 32 insertions, 12 deletions

diff --git a/webkit/glue/SConscript b/webkit/glue/SConscript
index 0828731..aa97721 100644
--- a/webkit/glue/SConscript
+++ b/webkit/glue/SConscript
@@ -112,6 +112,7 @@ elif env['PLATFORM'] == 'posix':
   input_files.extend([
       'webcursor_gtk.cc',
       'webinputevent_linux.cc',
+      'webkit_glue_gtk.cc',
   ])
 
 if env['PLATFORM'] in ('posix', 'darwin'):
diff --git a/webkit/glue/webkit_glue_gtk.cc b/webkit/glue/webkit_glue_gtk.cc
new file mode 100644
index 0000000..fc9c2fa
--- /dev/null
+++ b/webkit/glue/webkit_glue_gtk.cc
@@ -0,0 +1,23 @@
+// Copyright (c) 2008 The Chromium Authors. All rights reserved.  Use of this
+// source code is governed by a BSD-style license that can be found in the
+// LICENSE file.
+
+#include "webkit/glue/webkit_glue.h"
+
+#include <gtk/gtk.h>
+
+namespace webkit_glue {
+
+// TODO: complete this function
+ScreenInfo GetScreenInfoHelper(gfx::ViewHandle window) {
+  GdkScreen* screen = gtk_widget_get_screen(GTK_WIDGET(window));
+
+  ScreenInfo results;
+  results.rect.SetRect(0, 0, gdk_screen_get_width(screen),
+                       gdk_screen_get_height(screen));
+
+  return results;
+}
+
+}  // namespace webkit_glue
+
diff --git a/webkit/tools/test_shell/test_shell.cc b/webkit/tools/test_shell/test_shell.cc
index 6c1e535..04c45385 100644
--- a/webkit/tools/test_shell/test_shell.cc
+++ b/webkit/tools/test_shell/test_shell.cc
@@ -439,6 +439,10 @@ bool GetExeDirectory(std::wstring *path) {
   return PathService::Get(base::DIR_EXE, path);
 }
 
+ScreenInfo GetScreenInfo(gfx::ViewHandle window) {
+  return GetScreenInfoHelper(window);
+}
+
 bool SpellCheckWord(const wchar_t* word, int word_len,
                     int* misspelling_start, int* misspelling_len) {
   // Report all words being correctly spelled.
@@ -464,3 +468,4 @@ std::wstring GetWebKitLocale() {
 }
 
 }  // namespace webkit_glue
+
diff --git a/webkit/tools/test_shell/test_shell_gtk.cc b/webkit/tools/test_shell/test_shell_gtk.cc
index fbbc7ff..880a0fc 100644
--- a/webkit/tools/test_shell/test_shell_gtk.cc
+++ b/webkit/tools/test_shell/test_shell_gtk.cc
@@ -457,11 +457,5 @@ bool GetPlugins(bool refresh, std::vector<WebPluginInfo>* plugins) {
   return false;
 }
 
-ScreenInfo GetScreenInfo(gfx::ViewHandle window) {
-  // This should call GetScreenInfoHelper, which should be implemented in
-  // webkit_glue_gtk.cc
-  NOTIMPLEMENTED();
-  return ScreenInfo();
-}
-
 }  // namespace webkit_glue
+
diff --git a/webkit/tools/test_shell/test_shell_win.cc b/webkit/tools/test_shell/test_shell_win.cc
index 70db8dc..9a39528 100644
--- a/webkit/tools/test_shell/test_shell_win.cc
+++ b/webkit/tools/test_shell/test_shell_win.cc
@@ -716,8 +716,5 @@ bool DownloadUrl(const std::string& url, HWND caller_window) {
   return false;
 }
 
-ScreenInfo GetScreenInfo(gfx::ViewHandle window) {
-  return GetScreenInfoHelper(window);
-}
-
 }  // namespace webkit_glue
+
diff --git a/webkit/tools/test_shell/test_webview_delegate_gtk.cc b/webkit/tools/test_shell/test_webview_delegate_gtk.cc
index 1b93d9c..9583664 100644
--- a/webkit/tools/test_shell/test_webview_delegate_gtk.cc
+++ b/webkit/tools/test_shell/test_webview_delegate_gtk.cc
@@ -115,7 +115,7 @@ void TestWebViewDelegate::SetWindowRect(WebWidget* webwidget,
     GtkWidget* window =
         gtk_widget_get_parent(gtk_widget_get_parent(drawing_area));
     gtk_window_resize(GTK_WINDOW(window), rect.width(), rect.height());
-    gtk_window_move(GTK_WINDOW(window), rect.x(), -rect.y());
+    gtk_window_move(GTK_WINDOW(window), rect.x(), rect.y());
   }
 }