Coverity: Pass parameters by reference.

CID=7875,14289,17142,17143

R=kmadhusu@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7217030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90087 0039d316-1c4b-4281-b951-d872f2087c98

4 files changed, 10 insertions, 6 deletions

diff --git a/webkit/appcache/appcache_storage_impl.cc b/webkit/appcache/appcache_storage_impl.cc
index ef2a1b5..6b7d04d 100644
--- a/webkit/appcache/appcache_storage_impl.cc
+++ b/webkit/appcache/appcache_storage_impl.cc
@@ -1287,8 +1287,10 @@ bool AppCacheStorageImpl::FindResponseForMainRequestInGroup(
 }
 
 void AppCacheStorageImpl::DeliverShortCircuitedFindMainResponse(
-    const GURL& url, AppCacheEntry found_entry,
-    scoped_refptr<AppCacheGroup> group, scoped_refptr<AppCache> cache,
+    const GURL& url,
+    const AppCacheEntry& found_entry,
+    scoped_refptr<AppCacheGroup> group,
+    scoped_refptr<AppCache> cache,
     scoped_refptr<DelegateReference> delegate_ref) {
   if (delegate_ref->delegate) {
     DelegateReferenceVector delegates(1, delegate_ref);
diff --git a/webkit/appcache/appcache_storage_impl.h b/webkit/appcache/appcache_storage_impl.h
index 3da97db..6ef66d9 100644
--- a/webkit/appcache/appcache_storage_impl.h
+++ b/webkit/appcache/appcache_storage_impl.h
@@ -106,8 +106,10 @@ class AppCacheStorageImpl : public AppCacheStorage {
   bool FindResponseForMainRequestInGroup(
       AppCacheGroup* group,  const GURL& url, Delegate* delegate);
   void DeliverShortCircuitedFindMainResponse(
-      const GURL& url, AppCacheEntry found_entry,
-      scoped_refptr<AppCacheGroup> group, scoped_refptr<AppCache> newest_cache,
+      const GURL& url,
+      const AppCacheEntry& found_entry,
+      scoped_refptr<AppCacheGroup> group,
+      scoped_refptr<AppCache> newest_cache,
       scoped_refptr<DelegateReference> delegate_ref);
 
   void CheckPolicyAndCallOnMainResponseFound(
diff --git a/webkit/plugins/npapi/plugin_group.cc b/webkit/plugins/npapi/plugin_group.cc
index 15ec131..5a7803d 100644
--- a/webkit/plugins/npapi/plugin_group.cc
+++ b/webkit/plugins/npapi/plugin_group.cc
@@ -104,7 +104,7 @@ bool PluginGroup::IsPluginNameEnabledByPolicy(const string16& plugin_name) {
   return IsStringMatchedInSet(plugin_name, policy_enabled_plugin_patterns_);
 }
 
-VersionRange::VersionRange(VersionRangeDefinition definition)
+VersionRange::VersionRange(const VersionRangeDefinition& definition)
     : low_str(definition.version_matcher_low),
       high_str(definition.version_matcher_high),
       min_str(definition.min_version),
diff --git a/webkit/plugins/npapi/plugin_group.h b/webkit/plugins/npapi/plugin_group.h
index fd0f8e3..063713a 100644
--- a/webkit/plugins/npapi/plugin_group.h
+++ b/webkit/plugins/npapi/plugin_group.h
@@ -53,7 +53,7 @@ struct PluginGroupDefinition {
 // Run-time structure to hold version range information.
 struct VersionRange {
  public:
-  explicit VersionRange(VersionRangeDefinition definition);
+  explicit VersionRange(const VersionRangeDefinition& definition);
   VersionRange(const VersionRange& other);
   VersionRange& operator=(const VersionRange& other);
   ~VersionRange();