diff options
| author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-22 23:44:30 +0000 |
|---|---|---|
| committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-22 23:44:30 +0000 |
| commit | 3c4d38386f27b5fc4a7a8db717ea114725c34b4a (patch) | |
| tree | ce6e53d68638e8a1dd9fb672fbb72c10dd103f9d /webkit | |
| parent | 891c71789b6f3382a5edec024c8a478df523d7fd (diff) | |
| download | chromium_src-3c4d38386f27b5fc4a7a8db717ea114725c34b4a.zip chromium_src-3c4d38386f27b5fc4a7a8db717ea114725c34b4a.tar.gz chromium_src-3c4d38386f27b5fc4a7a8db717ea114725c34b4a.tar.bz2 | |
Fix reloading a page with a pdf not working. The problem was that we were sending an invalid window to DeferWindowPos (the previous window as it's going away). But we didn't really need to override setParentVisible since overriding setParent is enough.
Review URL: http://codereview.chromium.org/18519
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8521 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
| -rw-r--r-- | webkit/glue/webplugin_impl.cc | 13 | ||||
| -rw-r--r-- | webkit/glue/webplugin_impl.h | 1 |
2 files changed, 0 insertions, 14 deletions
diff --git a/webkit/glue/webplugin_impl.cc b/webkit/glue/webplugin_impl.cc index 811da21..a095b79 100644 --- a/webkit/glue/webplugin_impl.cc +++ b/webkit/glue/webplugin_impl.cc @@ -203,19 +203,6 @@ void WebPluginContainer::frameRectsChanged() { impl_->setFrameRect(frameRect()); } -// We override this function, to make sure that geometry updates are sent -// over to the plugin. For e.g. when a plugin is instantiated it does -// not have a valid parent. As a result the first geometry update from -// webkit is ignored. This function is called when the plugin eventually -// gets a parent. -void WebPluginContainer::setParentVisible(bool visible) { - WebCore::Widget::setParentVisible(visible); - if (visible) - show(); - else - hide(); -} - // We override this function so that if the plugin is windowed, we can call // NPP_SetWindow at the first possible moment. This ensures that NPP_SetWindow // is called before the manual load data is sent to a plugin. If this order is diff --git a/webkit/glue/webplugin_impl.h b/webkit/glue/webplugin_impl.h index 3654d3a..4f6782a 100644 --- a/webkit/glue/webplugin_impl.h +++ b/webkit/glue/webplugin_impl.h @@ -66,7 +66,6 @@ class WebPluginContainer : public WebCore::Widget { virtual void hide(); virtual void handleEvent(WebCore::Event* event); virtual void frameRectsChanged(); - virtual void setParentVisible(bool visible); virtual void setParent(WebCore::ScrollView* view); #if USE(JSC) |