diff options
author | ojan@google.com <ojan@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-02 18:42:36 +0000 |
---|---|---|
committer | ojan@google.com <ojan@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-02 18:42:36 +0000 |
commit | 01f123bd1fd410a29047ccbafab6b0305b484b50 (patch) | |
tree | 642d86559d5a8827fcfa5f61fccd9e134f2b4733 /webkit | |
parent | 93856f67bee9e1ba5e6438973bacfba4c37a767f (diff) | |
download | chromium_src-01f123bd1fd410a29047ccbafab6b0305b484b50.zip chromium_src-01f123bd1fd410a29047ccbafab6b0305b484b50.tar.gz chromium_src-01f123bd1fd410a29047ccbafab6b0305b484b50.tar.bz2 |
Quick fix for individual test view of the dashboard. We should
never exclude test results when in individual test view.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/178048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25209 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
-rw-r--r-- | webkit/tools/layout_tests/flakiness_dashboard.html | 15 |
1 files changed, 13 insertions, 2 deletions
diff --git a/webkit/tools/layout_tests/flakiness_dashboard.html b/webkit/tools/layout_tests/flakiness_dashboard.html index 50410cf..b4bc00e 100644 --- a/webkit/tools/layout_tests/flakiness_dashboard.html +++ b/webkit/tools/layout_tests/flakiness_dashboard.html @@ -678,9 +678,20 @@ tests.join('</div><div>') + '</div></div>'; } + /** + * Returns whether we should exclude test results from the test table. + * Note that we never want to exclude tests when we're in the individual + * tests view of the dashboard since the user is explicitly listing tests + * to view. + */ + function shouldHideTest(testResult) { + return !currentState.tests && + (test.isWontFix && !currentState.showWontFix || + test.meetsExpectations && !currentState.showCorrectExpectations); + } + function getHTMLForSingleTestRow(test, opt_builder) { - if ((test.isWontFix && !currentState.showWontFix) || - (test.meetsExpectations && !currentState.showCorrectExpectations)) { + if (shouldHideTest(test)) { // The innerHTML call is considerably faster if we exclude the rows for // items we're not showing than if we hide them using display:none. return ''; |