summaryrefslogtreecommitdiffstats
path: root/webkit
diff options
context:
space:
mode:
authorfischman@chromium.org <fischman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-12-10 00:26:16 +0000
committerfischman@chromium.org <fischman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-12-10 00:26:16 +0000
commit0f1388e5dac315f5f2057df49ba0ba1338bc3143 (patch)
tree4cf3579f42db02c6fd8a61b63a8e12118b278ae2 /webkit
parentd111e93688a8531eb6f3f48592dfbcb88a9a4fee (diff)
downloadchromium_src-0f1388e5dac315f5f2057df49ba0ba1338bc3143.zip
chromium_src-0f1388e5dac315f5f2057df49ba0ba1338bc3143.tar.gz
chromium_src-0f1388e5dac315f5f2057df49ba0ba1338bc3143.tar.bz2
<video> decode in hardware!
This uses the GpuVideoDecodeAccelerator machinery (already written to enable ppapi to take advantage of OpenMAX HW where available) to decode <video> data. This increases idle CPU from 20% to 45% on one particularly large (internal) test video (red0.mp4), on an ARM crosbook. HW decode is done on a best-effort basis; if the GPU code doesn't know how to deal with a codec/profile we still fall back to ffmpeg for decode. Because the vast majority of chrome installs will be on HW with no video decode support (yet) we only attempt HW video decode on platforms we know have a shot at it. BUG=104579 TEST=manual testing w/ video test matrix, trybots. Review URL: http://codereview.chromium.org/8686010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113895 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
-rw-r--r--webkit/media/webmediaplayer_impl.cc2
-rw-r--r--webkit/media/webvideoframe_impl.cc14
-rw-r--r--webkit/media/webvideoframe_impl.h13
3 files changed, 20 insertions, 9 deletions
diff --git a/webkit/media/webmediaplayer_impl.cc b/webkit/media/webmediaplayer_impl.cc
index a246945..a4eb991 100644
--- a/webkit/media/webmediaplayer_impl.cc
+++ b/webkit/media/webmediaplayer_impl.cc
@@ -700,6 +700,8 @@ void WebMediaPlayerImpl::putCurrentFrame(
WebVideoFrameImpl::toVideoFrame(web_video_frame));
proxy_->PutCurrentFrame(video_frame);
delete web_video_frame;
+ } else {
+ proxy_->PutCurrentFrame(NULL);
}
}
diff --git a/webkit/media/webvideoframe_impl.cc b/webkit/media/webvideoframe_impl.cc
index 5a5b182..93970f0 100644
--- a/webkit/media/webvideoframe_impl.cc
+++ b/webkit/media/webvideoframe_impl.cc
@@ -43,6 +43,8 @@ COMPILE_ASSERT_MATCHING_ENUM(FormatYV16, YV16);
COMPILE_ASSERT_MATCHING_ENUM(FormatNV12, NV12);
COMPILE_ASSERT_MATCHING_ENUM(FormatEmpty, EMPTY);
COMPILE_ASSERT_MATCHING_ENUM(FormatASCII, ASCII);
+COMPILE_ASSERT_MATCHING_ENUM(FormatI420, I420);
+COMPILE_ASSERT_MATCHING_ENUM(FormatNativeTexture, NATIVE_TEXTURE);
WebVideoFrame::Format WebVideoFrameImpl::format() const {
if (video_frame_.get())
@@ -75,9 +77,15 @@ int WebVideoFrameImpl::stride(unsigned plane) const {
}
const void* WebVideoFrameImpl::data(unsigned plane) const {
- if (video_frame_.get())
- return static_cast<const void*>(video_frame_->data(plane));
- return NULL;
+ if (!video_frame_.get() || format() == FormatNativeTexture)
+ return NULL;
+ return static_cast<const void*>(video_frame_->data(plane));
+}
+
+unsigned WebVideoFrameImpl::textureId() const {
+ if (!video_frame_.get() || format() != FormatNativeTexture)
+ return 0;
+ return video_frame_->texture_id();
}
} // namespace webkit_media
diff --git a/webkit/media/webvideoframe_impl.h b/webkit/media/webvideoframe_impl.h
index f82c4d7..72e81a5 100644
--- a/webkit/media/webvideoframe_impl.h
+++ b/webkit/media/webvideoframe_impl.h
@@ -19,12 +19,13 @@ class WebVideoFrameImpl : public WebKit::WebVideoFrame {
WebVideoFrameImpl(scoped_refptr<media::VideoFrame> video_frame);
virtual ~WebVideoFrameImpl();
- virtual WebVideoFrame::Format format() const OVERRIDE;
- virtual unsigned width() const OVERRIDE;
- virtual unsigned height() const OVERRIDE;
- virtual unsigned planes() const OVERRIDE;
- virtual int stride(unsigned plane) const OVERRIDE;
- virtual const void* data(unsigned plane) const OVERRIDE;
+ virtual WebVideoFrame::Format format() const;
+ virtual unsigned width() const;
+ virtual unsigned height() const;
+ virtual unsigned planes() const;
+ virtual int stride(unsigned plane) const;
+ virtual const void* data(unsigned plane) const;
+ virtual unsigned textureId() const;
private:
scoped_refptr<media::VideoFrame> video_frame_;