diff options
| author | jhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-29 21:17:13 +0000 |
|---|---|---|
| committer | jhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-29 21:17:13 +0000 |
| commit | 1c3dfac8bfaac6c32db3bfffe964bd0ca6ca1601 (patch) | |
| tree | 8711342823fced5a98b7578cfdeae90be204ff65 /webkit | |
| parent | 4993d71fe65634cfe75119f29859f046e4867b79 (diff) | |
| download | chromium_src-1c3dfac8bfaac6c32db3bfffe964bd0ca6ca1601.zip chromium_src-1c3dfac8bfaac6c32db3bfffe964bd0ca6ca1601.tar.gz chromium_src-1c3dfac8bfaac6c32db3bfffe964bd0ca6ca1601.tar.bz2 | |
Remove the element_ member of FormField, as we don't use it and shouldn't be using WebCore internals in glue anyway.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/342032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30512 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
| -rw-r--r-- | webkit/glue/form_field.cc | 9 | ||||
| -rw-r--r-- | webkit/glue/form_field.h | 12 | ||||
| -rw-r--r-- | webkit/glue/form_field_values.cc | 2 |
3 files changed, 5 insertions, 18 deletions
diff --git a/webkit/glue/form_field.cc b/webkit/glue/form_field.cc index 76992f5..665f498 100644 --- a/webkit/glue/form_field.cc +++ b/webkit/glue/form_field.cc @@ -6,15 +6,12 @@ namespace webkit_glue { -FormField::FormField() - : element_(NULL) { +FormField::FormField() { } -FormField::FormField(WebCore::HTMLFormControlElement* element, - const string16& name, +FormField::FormField(const string16& name, const string16& value) - : element_(element), - name_(name), + : name_(name), value_(value) { } diff --git a/webkit/glue/form_field.h b/webkit/glue/form_field.h index 3871881..224934d 100644 --- a/webkit/glue/form_field.h +++ b/webkit/glue/form_field.h @@ -7,31 +7,21 @@ #include "base/string16.h" -namespace WebCore { -class HTMLFormControlElement; -} - namespace webkit_glue { // Stores information about a field in a form. class FormField { public: FormField(); - FormField(WebCore::HTMLFormControlElement* element, - const string16& name, + FormField(const string16& name, const string16& value); - WebCore::HTMLFormControlElement* element() const { return element_; } string16 name() const { return name_; } string16 value() const { return value_; } - void set_element(WebCore::HTMLFormControlElement* element) { - element_ = element; - } void set_value(const string16& value) { value_ = value; } private: - WebCore::HTMLFormControlElement* element_; string16 name_; string16 value_; }; diff --git a/webkit/glue/form_field_values.cc b/webkit/glue/form_field_values.cc index 3afdedd..eccb1ce6 100644 --- a/webkit/glue/form_field_values.cc +++ b/webkit/glue/form_field_values.cc @@ -69,7 +69,7 @@ FormFieldValues* FormFieldValues::Create(const WebForm& webform) { if (name.length() == 0) continue; // If we have no name, there is nothing to store. - result->elements.push_back(FormField(form_element, name, value)); + result->elements.push_back(FormField(name, value)); } return result; |