diff options
| author | dglazkov@google.com <dglazkov@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-07 19:23:15 +0000 |
|---|---|---|
| committer | dglazkov@google.com <dglazkov@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-07 19:23:15 +0000 |
| commit | 26e86ef703e0621672442d74f5a984e75fedbaf8 (patch) | |
| tree | 79eeed7cb29fe9cfe69eaaaa29add4f2b12583cd /webkit | |
| parent | d8a96626d6619990001d32c17c336962fd9fb404 (diff) | |
| download | chromium_src-26e86ef703e0621672442d74f5a984e75fedbaf8.zip chromium_src-26e86ef703e0621672442d74f5a984e75fedbaf8.tar.gz chromium_src-26e86ef703e0621672442d74f5a984e75fedbaf8.tar.bz2 | |
Fix up V8 bindings code generator to allow unforking window.top part of DOMWindow.idl
R=mbelshe
BUG=10898
TEST=no new layout failures after this change
Review URL: http://codereview.chromium.org/114011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15566 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
| -rw-r--r-- | webkit/port/bindings/scripts/CodeGeneratorV8.pm | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/webkit/port/bindings/scripts/CodeGeneratorV8.pm b/webkit/port/bindings/scripts/CodeGeneratorV8.pm index 600b568..f3cb9aa 100644 --- a/webkit/port/bindings/scripts/CodeGeneratorV8.pm +++ b/webkit/port/bindings/scripts/CodeGeneratorV8.pm @@ -992,8 +992,17 @@ sub GenerateBatchedAttributeData # Replaceable accessor is put on instance template with ReadOnly attribute. $getter = "${interfaceName}Internal::${attrName}AttrGetter"; $setter = "0"; - $propAttr .= "|v8::ReadOnly"; - + + # Mark to avoid duplicate v8::ReadOnly flags in output. + $hasCustomSetter = 1; + + # Handle the special case of window.top being marked upstream as Replaceable. + # TODO(dglazkov): Investigate why Replaceable is not marked as ReadOnly + # upstream and reach parity. + if (!($interfaceName eq "DOMWindow" and $attrName eq "top")) { + $propAttr .= "|v8::ReadOnly"; + } + # Normal } else { $getter = "${interfaceName}Internal::${attrName}AttrGetter"; |