diff options
author | pfeldman@chromium.org <pfeldman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-02 10:32:21 +0000 |
---|---|---|
committer | pfeldman@chromium.org <pfeldman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-02 10:32:21 +0000 |
commit | 40247a925ac0e7f10051fe1789d0b99549966cc3 (patch) | |
tree | 83c3db742b565e15c2cceb8dff5ba2a1e592a1c9 /webkit | |
parent | 01b463f6ab8f50bdf5955d39c0fc520d1099d2fe (diff) | |
download | chromium_src-40247a925ac0e7f10051fe1789d0b99549966cc3.zip chromium_src-40247a925ac0e7f10051fe1789d0b99549966cc3.tar.gz chromium_src-40247a925ac0e7f10051fe1789d0b99549966cc3.tar.bz2 |
DevTools: Move InspectorController message filtering to the injected side.
Review URL: http://codereview.chromium.org/150219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19806 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
-rw-r--r-- | webkit/glue/devtools/js/devtools.js | 10 | ||||
-rw-r--r-- | webkit/glue/devtools/js/inject_dispatch.js | 7 |
2 files changed, 8 insertions, 9 deletions
diff --git a/webkit/glue/devtools/js/devtools.js b/webkit/glue/devtools/js/devtools.js index f8d055b..33ba39f 100644 --- a/webkit/glue/devtools/js/devtools.js +++ b/webkit/glue/devtools/js/devtools.js @@ -151,15 +151,7 @@ devtools.ToolsAgent.prototype.addMessageToConsole_ = function(message) { * @private */ devtools.ToolsAgent.prototype.dispatchOnClient_ = function(message) { - var messageObj = JSON.parse(message); - // Filter out messages we don't need here. - var method = messageObj[0]; - if (method == 'inspectedWindowCleared' || - method == 'reset' || - method == 'setAttachedWindow') { - return; - } - WebInspector.dispatch.apply(WebInspector, messageObj); + WebInspector.dispatch.apply(WebInspector, JSON.parse(message)); }; diff --git a/webkit/glue/devtools/js/inject_dispatch.js b/webkit/glue/devtools/js/inject_dispatch.js index a228ae8..0416676 100644 --- a/webkit/glue/devtools/js/inject_dispatch.js +++ b/webkit/glue/devtools/js/inject_dispatch.js @@ -47,6 +47,13 @@ var dispatch = function(method, var_args) { for (var i = 2; i < args.length; ++i) { args[i] = devtools$$obj.wrapConsoleObject(args[i]); } + } else if (method == 'inspectedWindowCleared' || + method == 'reset' || + method == 'setAttachedWindow') { + // Filter out messages we don't need here. + // We do it on the sender side since they may have non-serializable + // parameters. + return; } var call = JSON.stringify(args); DevToolsAgentHost.dispatch(call); |