summaryrefslogtreecommitdiffstats
path: root/webkit
diff options
context:
space:
mode:
authorager@chromium.org <ager@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-17 21:14:52 +0000
committerager@chromium.org <ager@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-17 21:14:52 +0000
commit86fd149aaa8d1e5d0e369dedf9e9ebe15ef137e8 (patch)
tree1ffb3c5c92d4d5285562eeb62aaab39002531593 /webkit
parent254f18b17b0985d80eff367e557adb53b1168661 (diff)
downloadchromium_src-86fd149aaa8d1e5d0e369dedf9e9ebe15ef137e8.zip
chromium_src-86fd149aaa8d1e5d0e369dedf9e9ebe15ef137e8.tar.gz
chromium_src-86fd149aaa8d1e5d0e369dedf9e9ebe15ef137e8.tar.bz2
Land Anton's change to cast from v8::Value to v8::Object before
converting a wrapper to a native Node pointer in devtools. BUG=none TEST=none Review URL: http://codereview.chromium.org/159003. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21002 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
-rw-r--r--webkit/glue/webdevtoolsclient_impl.cc6
1 files changed, 4 insertions, 2 deletions
diff --git a/webkit/glue/webdevtoolsclient_impl.cc b/webkit/glue/webdevtoolsclient_impl.cc
index eaf923f..19c0867 100644
--- a/webkit/glue/webdevtoolsclient_impl.cc
+++ b/webkit/glue/webdevtoolsclient_impl.cc
@@ -265,7 +265,8 @@ v8::Handle<v8::Value> WebDevToolsClientImpl::JsAddSourceToFrame(
if (source_string.isEmpty() || exception_catcher.HasCaught()) {
return v8::Undefined();
}
- Node* node = V8DOMWrapper::convertDOMWrapperToNode<Node>(args[2]);
+ v8::Handle<v8::Object> wrapper = v8::Handle<v8::Object>::Cast(args[2]);
+ Node* node = V8DOMWrapper::convertDOMWrapperToNode<Node>(wrapper);
if (!node || !node->attached()) {
return v8::Undefined();
}
@@ -284,7 +285,8 @@ v8::Handle<v8::Value> WebDevToolsClientImpl::JsAddResourceSourceToFrame(
if (mime_type.isEmpty()) {
return v8::Undefined();
}
- Node* node = V8DOMWrapper::convertDOMWrapperToNode<Node>(args[2]);
+ v8::Handle<v8::Object> wrapper = v8::Handle<v8::Object>::Cast(args[2]);
+ Node* node = V8DOMWrapper::convertDOMWrapperToNode<Node>(wrapper);
WebDevToolsClientImpl* client = static_cast<WebDevToolsClientImpl*>(
v8::External::Cast(*args.Data())->Value());
client->AddResourceSourceToFrame(resource_id, mime_type, node);