diff options
author | jianli@chromium.org <jianli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-05 20:37:12 +0000 |
---|---|---|
committer | jianli@chromium.org <jianli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-05 20:37:12 +0000 |
commit | c99613d0bc1dd6d06839ac72e08a8f2dc6e7fa6b (patch) | |
tree | 104d77187731893f12cc0f501ec2c5c4cc396d3a /webkit | |
parent | 1568d5ece313093ddfe8558dd14469780de37e61 (diff) | |
download | chromium_src-c99613d0bc1dd6d06839ac72e08a8f2dc6e7fa6b.zip chromium_src-c99613d0bc1dd6d06839ac72e08a8f2dc6e7fa6b.tar.gz chromium_src-c99613d0bc1dd6d06839ac72e08a8f2dc6e7fa6b.tar.bz2 |
Fix bug 23303: ui_tests crash Windows 7's shell when running WorkerHttpLayoutTests.
The crash is caused by lighttpd server starting on the foreground mode and it messed up with the command window host.
To work around this, we start the http server on the background mode if running UI test under Windows 7.
BUG=23303
TEST=none
Review URL: http://codereview.chromium.org/257047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28030 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
-rw-r--r-- | webkit/tools/layout_tests/layout_package/http_server.py | 16 |
1 files changed, 11 insertions, 5 deletions
diff --git a/webkit/tools/layout_tests/layout_package/http_server.py b/webkit/tools/layout_tests/layout_package/http_server.py index 2029ab1..9f328f6b 100644 --- a/webkit/tools/layout_tests/layout_package/http_server.py +++ b/webkit/tools/layout_tests/layout_package/http_server.py @@ -84,7 +84,7 @@ class Lighttpd: def __init__(self, output_dir, background=False, port=None, root=None, - register_cygwin=None): + register_cygwin=None, run_background=None): """Args: output_dir: the absolute path to the layout test result directory """ @@ -93,6 +93,7 @@ class Lighttpd: self._port = port self._root = root self._register_cygwin = register_cygwin + self._run_background = run_background if self._port: self._port = int(self._port) @@ -181,9 +182,11 @@ class Lighttpd: '-f', path_utils.PathFromBase(self._output_dir, 'lighttpd.conf'), # Where it can find its module dynamic libraries - '-m', module_path, - # Don't background - '-D' ] + '-m', module_path ] + + if not self._run_background: + start_cmd.append(# Don't background + '-D') # Copy liblightcomp.dylib to /tmp/lighttpd/lib to work around the bug that # mod_alias.so loads it from the hard coded path. @@ -278,6 +281,8 @@ if '__main__' == __name__: help='Absolute path to DocumentRoot (overrides layout test roots)') option_parser.add_option('--register_cygwin', action="store_true", dest="register_cygwin", help='Register Cygwin paths (on Win try bots)') + option_parser.add_option('--run_background', action="store_true", + dest="run_background", help='Run on background (for running as UI test)') options, args = option_parser.parse_args() if not options.server: @@ -292,7 +297,8 @@ if '__main__' == __name__: httpd = Lighttpd(tempfile.gettempdir(), port=options.port, root=options.root, - register_cygwin=options.register_cygwin) + register_cygwin=options.register_cygwin, + run_background=options.run_background) if 'start' == options.server: httpd.Start() else: |