diff options
| author | paul@chromium.org <paul@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-25 17:03:37 +0000 |
|---|---|---|
| committer | paul@chromium.org <paul@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-25 17:03:37 +0000 |
| commit | d82084b5348cdc559d6a1613bc46f0b557960c92 (patch) | |
| tree | dcc81990d77858973164c04e1eb38dc80542c1e8 /webkit | |
| parent | 8766556dd35a7295e2aef849a3ba33bedaa1106a (diff) | |
| download | chromium_src-d82084b5348cdc559d6a1613bc46f0b557960c92.zip chromium_src-d82084b5348cdc559d6a1613bc46f0b557960c92.tar.gz chromium_src-d82084b5348cdc559d6a1613bc46f0b557960c92.tar.bz2 | |
Don't call cancel on requests that have completed successfully.
Calling cancel in this case causes an unnecessary cancel IPC message
to be sent to the browser for every single URL we load, which then
unsuccessfully tries to look up the request. This triggers the logs
to fill up with the following message: "Canceling a request that
wasn't found". It also makes pinkerton sad.
TEST=Run in debug mode and notice the quiet output window
BUG=14494.
R=darin
Review URL: http://codereview.chromium.org/146067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19251 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
| -rw-r--r-- | webkit/glue/weburlloader_impl.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/webkit/glue/weburlloader_impl.cc b/webkit/glue/weburlloader_impl.cc index 5b2e0dd..d0158f6 100644 --- a/webkit/glue/weburlloader_impl.cc +++ b/webkit/glue/weburlloader_impl.cc @@ -455,6 +455,9 @@ void WebURLLoaderImpl::Context::OnCompletedRequest( multipart_delegate_.reset(NULL); } + // Prevent any further IPC to the browser now that we're complete. + bridge_.reset(); + if (client_) { if (status.status() != URLRequestStatus::SUCCESS) { int error_code; @@ -478,7 +481,6 @@ void WebURLLoaderImpl::Context::OnCompletedRequest( // We are done with the bridge now, and so we need to release the reference // to ourselves that we took on behalf of the bridge. This may cause our // destruction. - bridge_.reset(); Release(); } |