diff options
| author | bashi@chromium.org <bashi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-14 01:45:47 +0000 |
|---|---|---|
| committer | bashi@chromium.org <bashi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-14 01:45:47 +0000 |
| commit | 2d877a1b47407b4c224d10bd0ed189e14a54f489 (patch) | |
| tree | d22cb81664e9655238fcc4e62782633eb2507090 /webkit | |
| parent | 8aa1e6e66cc7c3eab00f3438262c4a309c9f9b92 (diff) | |
| download | chromium_src-2d877a1b47407b4c224d10bd0ed189e14a54f489.zip chromium_src-2d877a1b47407b4c224d10bd0ed189e14a54f489.tar.gz chromium_src-2d877a1b47407b4c224d10bd0ed189e14a54f489.tar.bz2 | |
Use references instead of pointers for WebPlugin::getFormValue().
We should use a reference an output argument to follow the WebKit coding
conventions.
TEST=compiled.
BUG=88896
Review URL: http://codereview.chromium.org/8912003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114338 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
| -rw-r--r-- | webkit/plugins/npapi/webplugin_impl.cc | 4 | ||||
| -rw-r--r-- | webkit/plugins/npapi/webplugin_impl.h | 2 | ||||
| -rw-r--r-- | webkit/plugins/ppapi/ppapi_webplugin_impl.cc | 2 | ||||
| -rw-r--r-- | webkit/plugins/ppapi/ppapi_webplugin_impl.h | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/webkit/plugins/npapi/webplugin_impl.cc b/webkit/plugins/npapi/webplugin_impl.cc index cd55d52..4e8f60f 100644 --- a/webkit/plugins/npapi/webplugin_impl.cc +++ b/webkit/plugins/npapi/webplugin_impl.cc @@ -279,13 +279,13 @@ NPObject* WebPluginImpl::scriptableObject() { return delegate_->GetPluginScriptableObject(); } -bool WebPluginImpl::getFormValue(WebKit::WebString* value) { +bool WebPluginImpl::getFormValue(WebKit::WebString& value) { if (!delegate_) return false; string16 form_value; if (!delegate_->GetFormValue(&form_value)) return false; - *value = form_value; + value = form_value; return true; } diff --git a/webkit/plugins/npapi/webplugin_impl.h b/webkit/plugins/npapi/webplugin_impl.h index e6c48de..843e4f1 100644 --- a/webkit/plugins/npapi/webplugin_impl.h +++ b/webkit/plugins/npapi/webplugin_impl.h @@ -69,7 +69,7 @@ class WEBKIT_PLUGINS_EXPORT WebPluginImpl : WebKit::WebPluginContainer* container); virtual void destroy(); virtual NPObject* scriptableObject(); - virtual bool getFormValue(WebKit::WebString* value); + virtual bool getFormValue(WebKit::WebString& value); virtual void paint( WebKit::WebCanvas* canvas, const WebKit::WebRect& paint_rect); virtual void updateGeometry( diff --git a/webkit/plugins/ppapi/ppapi_webplugin_impl.cc b/webkit/plugins/ppapi/ppapi_webplugin_impl.cc index 547e93c..015d57f 100644 --- a/webkit/plugins/ppapi/ppapi_webplugin_impl.cc +++ b/webkit/plugins/ppapi/ppapi_webplugin_impl.cc @@ -117,7 +117,7 @@ NPObject* WebPluginImpl::scriptableObject() { return message_channel_np_object; } -bool WebPluginImpl::getFormValue(WebString* value) { +bool WebPluginImpl::getFormValue(WebString& value) { return false; } diff --git a/webkit/plugins/ppapi/ppapi_webplugin_impl.h b/webkit/plugins/ppapi/ppapi_webplugin_impl.h index cca3c61..40e4178 100644 --- a/webkit/plugins/ppapi/ppapi_webplugin_impl.h +++ b/webkit/plugins/ppapi/ppapi_webplugin_impl.h @@ -43,7 +43,7 @@ class WebPluginImpl : public WebKit::WebPlugin { virtual bool initialize(WebKit::WebPluginContainer* container); virtual void destroy(); virtual NPObject* scriptableObject(); - virtual bool getFormValue(WebKit::WebString* value); + virtual bool getFormValue(WebKit::WebString& value); virtual void paint(WebKit::WebCanvas* canvas, const WebKit::WebRect& rect); virtual void updateGeometry( const WebKit::WebRect& frame_rect, |