diff options
author | tzik@chromium.org <tzik@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-01 11:27:05 +0000 |
---|---|---|
committer | tzik@chromium.org <tzik@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-01 11:27:05 +0000 |
commit | d48fed72396d8e39fb4e0c767adff46137184248 (patch) | |
tree | 58a328f1a1df8faea64e0b081a994455dda990d7 /webkit | |
parent | 5255d304cdf20a8f35553bb19d60d0abb6758464 (diff) | |
download | chromium_src-d48fed72396d8e39fb4e0c767adff46137184248.zip chromium_src-d48fed72396d8e39fb4e0c767adff46137184248.tar.gz chromium_src-d48fed72396d8e39fb4e0c767adff46137184248.tar.bz2 |
[FileAPI][Cleanup] Drop unused FileSystemOperation::NotifyCloseFile.
This function is no longer used since http://crrev.com/197290, and can be dropped safely.
BUG=220029
TEST="should not break build and existing tests"
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14682007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197600 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
7 files changed, 0 insertions, 31 deletions
diff --git a/webkit/chromeos/fileapi/remote_file_system_operation.cc b/webkit/chromeos/fileapi/remote_file_system_operation.cc index 59c339e..b85b5ed 100644 --- a/webkit/chromeos/fileapi/remote_file_system_operation.cc +++ b/webkit/chromeos/fileapi/remote_file_system_operation.cc @@ -200,15 +200,6 @@ void RemoteFileSystemOperation::OpenFile(const FileSystemURL& url, base::Owned(this), url, callback)); } -void RemoteFileSystemOperation::NotifyCloseFile( - const fileapi::FileSystemURL& url) { - DCHECK(SetPendingOperationType(kOperationCloseFile)); - remote_proxy_->NotifyCloseFile(url); - // Unlike other operations, NotifyCloseFile does not require callback. - // So it must be deleted here right now. - delete this; -} - fileapi::LocalFileSystemOperation* RemoteFileSystemOperation::AsLocalFileSystemOperation() { NOTIMPLEMENTED(); diff --git a/webkit/chromeos/fileapi/remote_file_system_operation.h b/webkit/chromeos/fileapi/remote_file_system_operation.h index ac920ac..85d1cfa 100644 --- a/webkit/chromeos/fileapi/remote_file_system_operation.h +++ b/webkit/chromeos/fileapi/remote_file_system_operation.h @@ -67,7 +67,6 @@ class RemoteFileSystemOperation : public fileapi::FileSystemOperation { int file_flags, base::ProcessHandle peer_handle, const OpenFileCallback& callback) OVERRIDE; - virtual void NotifyCloseFile(const fileapi::FileSystemURL& url) OVERRIDE; virtual fileapi::LocalFileSystemOperation* AsLocalFileSystemOperation() OVERRIDE; virtual void CreateSnapshotFile( diff --git a/webkit/fileapi/file_system_operation.h b/webkit/fileapi/file_system_operation.h index 15dd597..35e0a50 100644 --- a/webkit/fileapi/file_system_operation.h +++ b/webkit/fileapi/file_system_operation.h @@ -230,13 +230,6 @@ class FileSystemOperation { base::ProcessHandle peer_handle, const OpenFileCallback& callback) = 0; - // Notifies a file at |path| opened by OpenFile is closed in plugin process. - // File system will run some cleanup task such as uploading the modified file - // content to a remote storage. - // - // This function is used only by Pepper as of writing. - virtual void NotifyCloseFile(const FileSystemURL& path) = 0; - // For downcasting to FileSystemOperation. // TODO(kinuko): this hack should go away once appropriate upload-stream // handling based on element types is supported. diff --git a/webkit/fileapi/local_file_system_operation.cc b/webkit/fileapi/local_file_system_operation.cc index 5fb8e94..1e870c3 100644 --- a/webkit/fileapi/local_file_system_operation.cc +++ b/webkit/fileapi/local_file_system_operation.cc @@ -376,12 +376,6 @@ void LocalFileSystemOperation::OpenFile(const FileSystemURL& url, base::kNullProcessHandle)); } -void LocalFileSystemOperation::NotifyCloseFile(const FileSystemURL& url) { - // No particular task to do. This method is for remote file systems that - // need synchronization with remote server. - delete this; -} - // We can only get here on a write or truncate that's not yet completed. // We don't support cancelling any other operation at this time. void LocalFileSystemOperation::Cancel(const StatusCallback& cancel_callback) { diff --git a/webkit/fileapi/local_file_system_operation.h b/webkit/fileapi/local_file_system_operation.h index 08365c9..707c5d3 100644 --- a/webkit/fileapi/local_file_system_operation.h +++ b/webkit/fileapi/local_file_system_operation.h @@ -83,7 +83,6 @@ class WEBKIT_STORAGE_EXPORT LocalFileSystemOperation int file_flags, base::ProcessHandle peer_handle, const OpenFileCallback& callback) OVERRIDE; - virtual void NotifyCloseFile(const FileSystemURL& url) OVERRIDE; virtual void Cancel(const StatusCallback& cancel_callback) OVERRIDE; virtual LocalFileSystemOperation* AsLocalFileSystemOperation() OVERRIDE; virtual void CreateSnapshotFile( diff --git a/webkit/fileapi/syncable/syncable_file_system_operation.cc b/webkit/fileapi/syncable/syncable_file_system_operation.cc index 348aad9..32cfd4a 100644 --- a/webkit/fileapi/syncable/syncable_file_system_operation.cc +++ b/webkit/fileapi/syncable/syncable_file_system_operation.cc @@ -299,12 +299,6 @@ void SyncableFileSystemOperation::OpenFile( delete this; } -void SyncableFileSystemOperation::NotifyCloseFile( - const FileSystemURL& url) { - NOTREACHED(); - delete this; -} - void SyncableFileSystemOperation::Cancel( const StatusCallback& cancel_callback) { DCHECK(CalledOnValidThread()); diff --git a/webkit/fileapi/syncable/syncable_file_system_operation.h b/webkit/fileapi/syncable/syncable_file_system_operation.h index 2f07b39..4d6fc93 100644 --- a/webkit/fileapi/syncable/syncable_file_system_operation.h +++ b/webkit/fileapi/syncable/syncable_file_system_operation.h @@ -71,7 +71,6 @@ class WEBKIT_STORAGE_EXPORT SyncableFileSystemOperation int file_flags, base::ProcessHandle peer_handle, const OpenFileCallback& callback) OVERRIDE; - virtual void NotifyCloseFile(const fileapi::FileSystemURL& url) OVERRIDE; virtual void Cancel(const StatusCallback& cancel_callback) OVERRIDE; virtual void CreateSnapshotFile( const fileapi::FileSystemURL& path, |