fix build issue on Linux with GCC 4.1.2

related to non-virtual destructors in classes having virtual methods

BUG=1859

Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>.


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1860 0039d316-1c4b-4281-b951-d872f2087c98

4 files changed, 5 insertions, 1 deletions

diff --git a/webkit/glue/webplugin.h b/webkit/glue/webplugin.h
index 2e5268b..df634e4 100644
--- a/webkit/glue/webplugin.h
+++ b/webkit/glue/webplugin.h
@@ -133,6 +133,7 @@ class WebPlugin {
 // Simpler version of ResourceHandleClient that lends itself to proxying.
 class WebPluginResourceClient {
  public:
+  virtual ~WebPluginResourceClient() {}
   virtual void WillSendRequest(const GURL& url) = 0;
   virtual void DidReceiveResponse(const std::string& mime_type,
                                   const std::string& headers,
diff --git a/webkit/glue/webplugin_delegate.h b/webkit/glue/webplugin_delegate.h
index 56ab4c9..33990b3 100644
--- a/webkit/glue/webplugin_delegate.h
+++ b/webkit/glue/webplugin_delegate.h
@@ -23,6 +23,7 @@ class WebPluginResourceClient;
 class WebPluginDelegate {
  public:
   WebPluginDelegate() {}
+  virtual ~WebPluginDelegate() {}
 
   // Initializes the plugin implementation with the given (UTF8) arguments.
   // Note that the lifetime of WebPlugin must be longer than this delegate.
diff --git a/webkit/port/history/BackForwardList.h b/webkit/port/history/BackForwardList.h
index 6eca334..ec54818 100644
--- a/webkit/port/history/BackForwardList.h
+++ b/webkit/port/history/BackForwardList.h
@@ -57,6 +57,7 @@ typedef HashSet<RefPtr<HistoryItem> > HistoryItemHashSet;
 // back-forward list.
 class BackForwardListClient {
 public:
+    virtual ~BackForwardListClient() {}
     virtual void didAddHistoryItem(HistoryItem* item) = 0;
     virtual void willGoToHistoryItem(HistoryItem* item) = 0;
     virtual HistoryItem* itemAtIndex(int index) = 0;
diff --git a/webkit/port/platform/WidgetClientWin.h b/webkit/port/platform/WidgetClientWin.h
index 50b9445..40355cc 100644
--- a/webkit/port/platform/WidgetClientWin.h
+++ b/webkit/port/platform/WidgetClientWin.h
@@ -19,6 +19,8 @@ class Range;
 // Generic interface for features needed by the Widget.
 class WidgetClientWin : public WidgetClient {
 public:
+    virtual ~WidgetClientWin() {}
+
     // Returns the containing window for the Widget.
     // TODO(pinkerton): this needs a better name, "window" is incorrect on other
     // platforms.
@@ -68,4 +70,3 @@ public:
 } // namespace WebCore
 
 #endif  // WidgetClientWin_H__
-