summaryrefslogtreecommitdiffstats
path: root/webkit
diff options
context:
space:
mode:
authorjhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-06-22 04:21:10 +0000
committerjhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-06-22 04:21:10 +0000
commit92d5d525fc362abbf882d045261373a17798c043 (patch)
tree3e9ca61bef4e49726c5383de8f21a8bb34d1bd2a /webkit
parent1264b8bdf52d38e7a32b7b7de9737ea0a307bdd7 (diff)
downloadchromium_src-92d5d525fc362abbf882d045261373a17798c043.zip
chromium_src-92d5d525fc362abbf882d045261373a17798c043.tar.gz
chromium_src-92d5d525fc362abbf882d045261373a17798c043.tar.bz2
Coverity: Pass parameters by reference.
CID=8725,14376,15499,15540,15655,16687,16688 BUG=none TEST=none R=kmadhusu@chromium.org Review URL: http://codereview.chromium.org/7211037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89976 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
-rw-r--r--webkit/plugins/npapi/plugin_list_win.cc2
-rw-r--r--webkit/plugins/ppapi/file_path.cc2
-rw-r--r--webkit/plugins/ppapi/file_path.h2
-rw-r--r--webkit/plugins/ppapi/ppb_context_3d_impl.cc3
-rw-r--r--webkit/quota/quota_manager.cc4
5 files changed, 7 insertions, 6 deletions
diff --git a/webkit/plugins/npapi/plugin_list_win.cc b/webkit/plugins/npapi/plugin_list_win.cc
index 6e41f2d..cbd16ca 100644
--- a/webkit/plugins/npapi/plugin_list_win.cc
+++ b/webkit/plugins/npapi/plugin_list_win.cc
@@ -221,7 +221,7 @@ void GetJavaDirectory(std::set<FilePath>* plugin_dirs) {
}
}
-bool IsValid32BitImage(FilePath path) {
+bool IsValid32BitImage(const FilePath& path) {
file_util::MemoryMappedFile plugin_image;
if (!plugin_image.InitializeAsImageSection(path))
diff --git a/webkit/plugins/ppapi/file_path.cc b/webkit/plugins/ppapi/file_path.cc
index 95408c2..14d8970 100644
--- a/webkit/plugins/ppapi/file_path.cc
+++ b/webkit/plugins/ppapi/file_path.cc
@@ -32,7 +32,7 @@ PepperFilePath::PepperFilePath()
path_() {
}
-PepperFilePath::PepperFilePath(Domain domain, FilePath path)
+PepperFilePath::PepperFilePath(Domain domain, const FilePath& path)
: domain_(domain),
path_(path) {
// TODO(viettrungluu): Should we DCHECK() some things here?
diff --git a/webkit/plugins/ppapi/file_path.h b/webkit/plugins/ppapi/file_path.h
index 8a3851e..5630ca4 100644
--- a/webkit/plugins/ppapi/file_path.h
+++ b/webkit/plugins/ppapi/file_path.h
@@ -30,7 +30,7 @@ class PepperFilePath {
};
PepperFilePath();
- PepperFilePath(Domain d, FilePath p);
+ PepperFilePath(Domain d, const FilePath& p);
static PepperFilePath MakeAbsolute(const FilePath& path);
static PepperFilePath MakeModuleLocal(PluginModule* module,
diff --git a/webkit/plugins/ppapi/ppb_context_3d_impl.cc b/webkit/plugins/ppapi/ppb_context_3d_impl.cc
index 3c581c6..4fd8826 100644
--- a/webkit/plugins/ppapi/ppb_context_3d_impl.cc
+++ b/webkit/plugins/ppapi/ppb_context_3d_impl.cc
@@ -40,7 +40,8 @@ bool ShmToHandle(base::SharedMemory* shm,
return true;
}
-PP_Context3DTrustedState PPStateFromGPUState(gpu::CommandBuffer::State s) {
+PP_Context3DTrustedState PPStateFromGPUState(
+ const gpu::CommandBuffer::State& s) {
PP_Context3DTrustedState state = {
s.num_entries,
s.get_offset,
diff --git a/webkit/quota/quota_manager.cc b/webkit/quota/quota_manager.cc
index 52cd4eb..671e599b 100644
--- a/webkit/quota/quota_manager.cc
+++ b/webkit/quota/quota_manager.cc
@@ -265,7 +265,7 @@ class QuotaManager::UsageAndQuotaDispatcherTaskForTemporary
: public QuotaManager::UsageAndQuotaDispatcherTask {
public:
UsageAndQuotaDispatcherTaskForTemporary(
- QuotaManager* manager, const std::string host)
+ QuotaManager* manager, const std::string& host)
: UsageAndQuotaDispatcherTask(manager, host, kStorageTypeTemporary) {}
protected:
@@ -309,7 +309,7 @@ class QuotaManager::UsageAndQuotaDispatcherTaskForPersistent
: public QuotaManager::UsageAndQuotaDispatcherTask {
public:
UsageAndQuotaDispatcherTaskForPersistent(
- QuotaManager* manager, const std::string host)
+ QuotaManager* manager, const std::string& host)
: UsageAndQuotaDispatcherTask(manager, host, kStorageTypePersistent) {}
protected: