summaryrefslogtreecommitdiffstats
path: root/webkit
diff options
context:
space:
mode:
authorvollick@chromium.org <vollick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-02-09 03:10:34 +0000
committervollick@chromium.org <vollick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-02-09 03:10:34 +0000
commit2164392236536f14f2de6aa8e80340d6f01401fd (patch)
tree528a625e83cf8293c62ed0adf83b416f95f4f7c8 /webkit
parentadb0fd7992ddc7c94741471fe54f68757491f156 (diff)
downloadchromium_src-2164392236536f14f2de6aa8e80340d6f01401fd.zip
chromium_src-2164392236536f14f2de6aa8e80340d6f01401fd.tar.gz
chromium_src-2164392236536f14f2de6aa8e80340d6f01401fd.tar.bz2
Split preserve3d into: "should-flatten" and "is-3d-sorted"
Preserve3d has implications for both sorting and flattening of transforms. This is a bummer. Sometimes we want to allow a transform to remain unflattened, but we don't want that to affect 3d sorting. With this CL, we will have the ability to do that. Note: this is essentially this cl https://codereview.chromium.org/100393005/ ..minus the generalizations to sorting that were being attempted in that patch. Note, this CL is gated on https://codereview.chromium.org/98373011/ R=enne@chromium.org BUG=338980 Review URL: https://codereview.chromium.org/147833003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249974 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
-rw-r--r--webkit/renderer/compositor_bindings/web_layer_impl.cc10
-rw-r--r--webkit/renderer/compositor_bindings/web_layer_impl.h1
2 files changed, 5 insertions, 6 deletions
diff --git a/webkit/renderer/compositor_bindings/web_layer_impl.cc b/webkit/renderer/compositor_bindings/web_layer_impl.cc
index 4ecf019..6deeb0e 100644
--- a/webkit/renderer/compositor_bindings/web_layer_impl.cc
+++ b/webkit/renderer/compositor_bindings/web_layer_impl.cc
@@ -188,13 +188,13 @@ void WebLayerImpl::setDrawsContent(bool draws_content) {
bool WebLayerImpl::drawsContent() const { return layer_->DrawsContent(); }
-void WebLayerImpl::setPreserves3D(bool preserve3D) {
- layer_->SetPreserves3d(preserve3D);
+void WebLayerImpl::setShouldFlattenTransform(bool flatten) {
+ layer_->SetShouldFlattenTransform(flatten);
}
-void WebLayerImpl::setShouldFlattenTransform(bool flatten) { }
-
-void WebLayerImpl::setRenderingContext(int context) { }
+void WebLayerImpl::setRenderingContext(int context) {
+ layer_->SetIs3dSorted(context > 0);
+}
void WebLayerImpl::setUseParentBackfaceVisibility(
bool use_parent_backface_visibility) {
diff --git a/webkit/renderer/compositor_bindings/web_layer_impl.h b/webkit/renderer/compositor_bindings/web_layer_impl.h
index c730620..fc5613b 100644
--- a/webkit/renderer/compositor_bindings/web_layer_impl.h
+++ b/webkit/renderer/compositor_bindings/web_layer_impl.h
@@ -91,7 +91,6 @@ class WebLayerImpl : public blink::WebLayer, public cc::LayerClient {
virtual SkMatrix44 transform() const;
virtual void setDrawsContent(bool draws_content);
virtual bool drawsContent() const;
- virtual void setPreserves3D(bool preserves_3d);
virtual void setShouldFlattenTransform(bool flatten);
virtual void setRenderingContext(int context);
virtual void setUseParentBackfaceVisibility(bool visible);