summaryrefslogtreecommitdiffstats
path: root/webkit
diff options
context:
space:
mode:
authorkaiwang@chromium.org <kaiwang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-01-23 04:12:17 +0000
committerkaiwang@chromium.org <kaiwang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-01-23 04:12:17 +0000
commitde415556289c07f6a28bec79405d413460b186d2 (patch)
tree6664e471f3383e96c9f768750ad25d75cab567dc /webkit
parent042b62dec29c560ccf3e5bfdbf658c11adb56f0b (diff)
downloadchromium_src-de415556289c07f6a28bec79405d413460b186d2.zip
chromium_src-de415556289c07f6a28bec79405d413460b186d2.tar.gz
chromium_src-de415556289c07f6a28bec79405d413460b186d2.tar.bz2
Only HistogramBase is used outside of base/metrics.
So client code of histogram will see a simpler interface. This also makes adding SparseHistogram to existing metrics framework possible. This CL depends on https://codereview.chromium.org/11682003/ So please review that one first. TBR=sky@chromium.org,erikwright@chromium.org BUG=139612 Review URL: https://chromiumcodereview.appspot.com/11615008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178242 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
-rw-r--r--webkit/glue/webkitplatformsupport_impl.cc8
-rw-r--r--webkit/plugins/ppapi/ppb_uma_private_impl.cc12
2 files changed, 10 insertions, 10 deletions
diff --git a/webkit/glue/webkitplatformsupport_impl.cc b/webkit/glue/webkitplatformsupport_impl.cc
index a199422..6ebd52a 100644
--- a/webkit/glue/webkitplatformsupport_impl.cc
+++ b/webkit/glue/webkitplatformsupport_impl.cc
@@ -418,9 +418,9 @@ void WebKitPlatformSupportImpl::histogramCustomCounts(
const char* name, int sample, int min, int max, int bucket_count) {
// Copied from histogram macro, but without the static variable caching
// the histogram because name is dynamic.
- base::Histogram* counter =
+ base::HistogramBase* counter =
base::Histogram::FactoryGet(name, min, max, bucket_count,
- base::Histogram::kUmaTargetedHistogramFlag);
+ base::HistogramBase::kUmaTargetedHistogramFlag);
DCHECK_EQ(name, counter->histogram_name());
counter->Add(sample);
}
@@ -429,9 +429,9 @@ void WebKitPlatformSupportImpl::histogramEnumeration(
const char* name, int sample, int boundary_value) {
// Copied from histogram macro, but without the static variable caching
// the histogram because name is dynamic.
- base::Histogram* counter =
+ base::HistogramBase* counter =
base::LinearHistogram::FactoryGet(name, 1, boundary_value,
- boundary_value + 1, base::Histogram::kUmaTargetedHistogramFlag);
+ boundary_value + 1, base::HistogramBase::kUmaTargetedHistogramFlag);
DCHECK_EQ(name, counter->histogram_name());
counter->Add(sample);
}
diff --git a/webkit/plugins/ppapi/ppb_uma_private_impl.cc b/webkit/plugins/ppapi/ppb_uma_private_impl.cc
index ec85c16..fb30a06 100644
--- a/webkit/plugins/ppapi/ppb_uma_private_impl.cc
+++ b/webkit/plugins/ppapi/ppb_uma_private_impl.cc
@@ -36,13 +36,13 @@ void HistogramCustomTimes(PP_Var name,
StringVar* name_string = StringVar::FromPPVar(name);
if (name_string == NULL)
return;
- base::Histogram* counter =
+ base::HistogramBase* counter =
base::Histogram::FactoryTimeGet(
name_string->value(),
base::TimeDelta::FromMilliseconds(min),
base::TimeDelta::FromMilliseconds(max),
bucket_count,
- base::Histogram::kUmaTargetedHistogramFlag);
+ base::HistogramBase::kUmaTargetedHistogramFlag);
counter->AddTime(base::TimeDelta::FromMilliseconds(sample));
}
@@ -55,13 +55,13 @@ void HistogramCustomCounts(PP_Var name,
StringVar* name_string = StringVar::FromPPVar(name);
if (name_string == NULL)
return;
- base::Histogram* counter =
+ base::HistogramBase* counter =
base::Histogram::FactoryGet(
name_string->value(),
min,
max,
bucket_count,
- base::Histogram::kUmaTargetedHistogramFlag);
+ base::HistogramBase::kUmaTargetedHistogramFlag);
counter->Add(sample);
}
@@ -73,13 +73,13 @@ void HistogramEnumeration(PP_Var name,
StringVar* name_string = StringVar::FromPPVar(name);
if (name_string == NULL)
return;
- base::Histogram* counter =
+ base::HistogramBase* counter =
base::LinearHistogram::FactoryGet(
name_string->value(),
1,
boundary_value,
boundary_value + 1,
- base::Histogram::kUmaTargetedHistogramFlag);
+ base::HistogramBase::kUmaTargetedHistogramFlag);
counter->Add(sample);
}