diff options
| author | kinuko@chromium.org <kinuko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-24 07:44:50 +0000 |
|---|---|---|
| committer | kinuko@chromium.org <kinuko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-24 07:44:50 +0000 |
| commit | 48383f39a630691a792ca2a55a28e4c3c90fd85c (patch) | |
| tree | 83e7124adf2c0792714682ec46314483e12ca5c8 /webkit | |
| parent | ed5d5a9dd90f3e6e558fa088c90d0300a7ca4027 (diff) | |
| download | chromium_src-48383f39a630691a792ca2a55a28e4c3c90fd85c.zip chromium_src-48383f39a630691a792ca2a55a28e4c3c90fd85c.tar.gz chromium_src-48383f39a630691a792ca2a55a28e4c3c90fd85c.tar.bz2 | |
Enable regular warnings for webkit/storage code (and fix them)
BUG=none
Review URL: https://codereview.chromium.org/39243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230673 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit')
| -rw-r--r-- | webkit/browser/blob/view_blob_internals_job.cc | 1 | ||||
| -rw-r--r-- | webkit/browser/fileapi/local_file_stream_writer.cc | 4 | ||||
| -rw-r--r-- | webkit/browser/quota/quota_manager.cc | 4 | ||||
| -rw-r--r-- | webkit/storage_browser.gyp | 3 | ||||
| -rw-r--r-- | webkit/storage_common.gyp | 3 |
5 files changed, 10 insertions, 5 deletions
diff --git a/webkit/browser/blob/view_blob_internals_job.cc b/webkit/browser/blob/view_blob_internals_job.cc index dc7d905..fa9e82a 100644 --- a/webkit/browser/blob/view_blob_internals_job.cc +++ b/webkit/browser/blob/view_blob_internals_job.cc @@ -24,7 +24,6 @@ namespace { const char kEmptyBlobStorageMessage[] = "No available blob data."; -const char kRemove[] = "Remove"; const char kContentType[] = "Content Type: "; const char kContentDisposition[] = "Content Disposition: "; const char kCount[] = "Count: "; diff --git a/webkit/browser/fileapi/local_file_stream_writer.cc b/webkit/browser/fileapi/local_file_stream_writer.cc index 75c2cad..1796de5 100644 --- a/webkit/browser/fileapi/local_file_stream_writer.cc +++ b/webkit/browser/fileapi/local_file_stream_writer.cc @@ -84,9 +84,9 @@ LocalFileStreamWriter::LocalFileStreamWriter(base::TaskRunner* task_runner, int64 initial_offset) : file_path_(file_path), initial_offset_(initial_offset), + task_runner_(task_runner), has_pending_operation_(false), - weak_factory_(this), - task_runner_(task_runner) {} + weak_factory_(this) {} int LocalFileStreamWriter::InitiateOpen( const net::CompletionCallback& error_callback, diff --git a/webkit/browser/quota/quota_manager.cc b/webkit/browser/quota/quota_manager.cc index 0f445a0..3014fbb 100644 --- a/webkit/browser/quota/quota_manager.cc +++ b/webkit/browser/quota/quota_manager.cc @@ -805,8 +805,8 @@ QuotaManager::QuotaManager(bool is_incognito, temporary_quota_override_(-1), desired_available_space_(-1), special_storage_policy_(special_storage_policy), - weak_factory_(this), - get_disk_space_fn_(&CallSystemGetAmountOfFreeDiskSpace) { + get_disk_space_fn_(&CallSystemGetAmountOfFreeDiskSpace), + weak_factory_(this) { } void QuotaManager::GetUsageInfo(const GetUsageInfoCallback& callback) { diff --git a/webkit/storage_browser.gyp b/webkit/storage_browser.gyp index 23f2f93..9e5393c 100644 --- a/webkit/storage_browser.gyp +++ b/webkit/storage_browser.gyp @@ -3,6 +3,9 @@ # found in the LICENSE file. { + 'variables': { + 'chromium_code': 1, + }, 'targets': [ { 'target_name': 'webkit_storage_browser', diff --git a/webkit/storage_common.gyp b/webkit/storage_common.gyp index a77d4c5..51181fe 100644 --- a/webkit/storage_common.gyp +++ b/webkit/storage_common.gyp @@ -3,6 +3,9 @@ # found in the LICENSE file. { + 'variables': { + 'chromium_code': 1, + }, 'targets': [ { 'target_name': 'webkit_storage_common', |